Fix: Allow unlimited query parameters in extended parser#7116
Closed
nmurrell07 wants to merge 1 commit intoexpressjs:masterfrom
Closed
Fix: Allow unlimited query parameters in extended parser#7116nmurrell07 wants to merge 1 commit intoexpressjs:masterfrom
nmurrell07 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
The qs library has a default parameterLimit of 1000, which silently truncates query parameters beyond that limit. This can cause data loss when handling requests with many query parameters. Fix by setting parameterLimit: Infinity in the parseExtendedQueryString function, allowing all query parameters to be parsed. Fixes: expressjs#5878
krzysdz
suggested changes
Mar 21, 2026
nmurrell07
pushed a commit
to nmurrell07/express
that referenced
this pull request
Mar 21, 2026
- Change default query parser from 'simple' to 'extended' - Add 'query parser limit' setting with default of 10000 - Pass limit to query parser at parse time (not compile time) - Fixes issue expressjs#5878 - query params truncated at 1000+ params - Supersedes PR expressjs#7116 which used Infinity (security concern)
nmurrell07
pushed a commit
to nmurrell07/express
that referenced
this pull request
Mar 21, 2026
- Change default query parser from 'simple' to 'extended' - Add 'query parser limit' setting with default of 10000 - Pass limit to query parser at parse time (not compile time) - Fixes issue expressjs#5878 - query params truncated at 1000+ params - Supersedes PR expressjs#7116 which used Infinity (security concern)
Contributor
|
Superseded by #7117 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qs library has a default parameterLimit of 1000, which silently truncates query parameters beyond that limit. This can cause data loss when handling requests with many query parameters.
Fix by setting parameterLimit: Infinity in the parseExtendedQueryString function, allowing all query parameters to be parsed.
Fixes: #5878