Skip to content

Overhaul#77

Open
kbvernon wants to merge 20 commits intoextendr:mainfrom
kbvernon:overhaul
Open

Overhaul#77
kbvernon wants to merge 20 commits intoextendr:mainfrom
kbvernon:overhaul

Conversation

@kbvernon
Copy link
Collaborator

@kbvernon kbvernon commented Mar 13, 2026

Addresses #76

Changes:

  1. Added consistent styling and official palette in extendr.scss
  2. Added contributor guide (or the start of one)
  3. Consolidated text and content in intro-rust and added more output for examples (showing result of cargo run --quiet)
  4. Moved most of the user-guide into _drafts (these will be brought out and updated once we move to new r/extendr)
  5. Simplified the landing page
  6. Added dark mode
  7. Switched to flatly bootswatch
  8. Added _variables.yml to make it easier to update R, Rust, extendr, and rextendr version numbers everywhere they are referenced.
  9. Added iconify quarto extension

Comment on lines +27 to +28
- Every exported function in rextendr must include the following roxygen
variables:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Every exported function in rextendr must include the following roxygen
variables:
roclets:

- the default value, if one exists
- `@return` — what the function returns, including the R type.
- The `@details` and `@examples` sections are optional, but should in general be
included.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples are required by CRAN. this is not optional

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this go?

Comment on lines +198 to +199
Shell scripts run by R when the package is uninstalled. They remove the
generated `src/Makevars` and `src/Makevars.win` files respectively. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. These are run at the end of package installation

Comment on lines +1 to +5
version:
r: "4.2"
rust: "1.65.0"
extendr: "0.8.1"
rextendr: "0.4.2.9000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm anti yaml.

Think we can change this to?

[versions]
r = "4.5"
rust = "1.71"
rextendr = "0.4"

Can read it with tomledit::read_toml(".variables.toml")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Quarto feature that allows us to insert them into text using {{< var version.r >}} syntax. Should make it easier to update version numbers everywhere when that comes up. That said, we can use toml and do inline R code everywhere instead. Or neither! Whatever you think is best!

CLAUDE.md Outdated
## Codebase

**extendr**
version: 0.8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is gonna trip claude up. This is the type of false flag that claude LOVES to get hung up on!

Suggested change
version: 0.8.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not mean to commit CLAUDE.md. That's my bad. I think we should work on a Claude skills repo instead.

CLAUDE.md Outdated
need to understand extendr's API, types, macros, or implementation details.

**rextendr**
version: 0.4.2.9000 (dev)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.4.2.9000 (dev)

@JosiahParry
Copy link
Contributor

image lol

we need docs here:

For all new functionality we require tests to ensure they continue to work as intended. For bug fixes we require a test to cover the bug fix (if one didn't exist yet).

rextendr

  • we use testthat to test functionality
  • avoid adding new snaptshots whenever. snapshot tests are not indiciative of behavior

extendr-api

Two types of tests:

use the justfile to help run these with just document then just devtools-test and for rust tests just test and then also ensure that things are formatted with just fmt

@JosiahParry
Copy link
Contributor

extendr-internals : lets add a callout note coming soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants