feat: add support for configmaps as source#241
Open
pepordev wants to merge 2 commits intoexternal-secrets:mainfrom
Open
feat: add support for configmaps as source#241pepordev wants to merge 2 commits intoexternal-secrets:mainfrom
pepordev wants to merge 2 commits intoexternal-secrets:mainfrom
Conversation
pepordev
force-pushed
the
feat/support-configmaps-as-source
branch
3 times, most recently
from
9ddb6d5 to
e829bc0
Compare
Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
pepordev
force-pushed
the
feat/support-configmaps-as-source
branch
from
e829bc0 to
36b7b52
Compare
Skarlso
reviewed
Feb 28, 2026
DEVELOPING.md
Outdated
| @@ -0,0 +1,220 @@ | |||
| # Developing the Reloader Controller | |||
Contributor
There was a problem hiding this comment.
We don't really need this. I mean, this is something I'm guessing your llm came up with? I much rather read something that a human wrote. The quick section and the project layout are particularly useless since it's ephemeral. We might be moving stuff around soon and I don't want something that I would have to keep updated every time I rename a package.
Contributor
|
The doc can be removed, the rest looks okay. |
Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
Skarlso
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #240
This would allow configmaps to be set as source and also make the external-secrets to validate
spec.target.template.templateFrom[].configMap.namepaths