Open
Conversation
feature(label stroke): add stroke for simple colours, need to fix gradient colors # Conflicts: # Source/Model/Nodes/SVGText.swift code refactoring, need to fix position for plain stroke labels # Conflicts: # Source/Model/Nodes/SVGText.swift chagne stroke width to ratio of font size, add getFont method change plain stroke label frame code refactoring add all in one, stoke and fill case add locations to gradient funcs add macOS support fix position change bug, change getLabelSize to getHeightOfLabel fix bug with background for filled label change Linear Gradient alignmentGuide, fix bounds for stroke label and stroke gradient change position code of gradient and stroke labels, fix decreasing height of stroke label bug code refactoring fix position for OSX and ios Add radial gradient support for iOS and OSX code refactoring change tabs to 4 spaces code refactoring code refactoring refactoring: fix createOneColorStrokeLabel fix createGradientStrokeLabel fix createFillGradientLabel fix createRadialGradientStrokeLabel and createRadialGradientFillLabel fix createOneColorFillLabel, codestyle fix delete getLabelHeight, leave only one version of SVGGUITextView add getStrokeBounds func code refactoring fix codestyle fix bugs
Abbasov-Ruslan
force-pushed
the
label-stroke
branch
from
6ca92cf to
704dfe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fill and stroke support for labels