fix: remove viewport clipping to prevent stroke cutoff#72
Open
hongminpark wants to merge 1 commit intoexyte:mainfrom
Open
fix: remove viewport clipping to prevent stroke cutoff#72hongminpark wants to merge 1 commit intoexyte:mainfrom
hongminpark wants to merge 1 commit intoexyte:mainfrom
Conversation
When SVG elements have strokes that extend beyond their viewport bounds, the .clipped() modifier would cut them off. This change allows strokes to render fully outside their nominal bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SVG elements have strokes that extend beyond their viewport bounds, the
.clipped()modifier would cut them off. This change allows strokes to render fully outside their nominal bounds.Problem
When using SVG shapes with strokes, especially with larger stroke widths, the strokes can get clipped at the viewport boundaries. This is because the
.clipped()modifier inSVGViewportViewforces the content to stay within its frame.Solution
Remove the
.clipped()modifier fromSVGViewportViewto allow strokes to render beyond the viewport bounds. This maintains the same viewport sizing and transformation behavior while allowing strokes to be fully visible.Testing
Tested with SVG shapes using various stroke widths and confirmed that: