Handle NaN and Infinity in JSON serialization | Fixes #4144#4754
Closed
sswez02 wants to merge 1 commit intofacebook:mainfrom
Closed
Handle NaN and Infinity in JSON serialization | Fixes #4144#4754sswez02 wants to merge 1 commit intofacebook:mainfrom
sswez02 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4144
Problem
When saving a Client to JSON using
save_to_json_file(), the operation fails withValueError: Out of range float values are not JSON compliantbecauseNaNandInfinityfloat values are not valid in standard JSON format.Solution
Modified
ax/storage/json_store/encoder.pyto handle non-JSON-compliant float values:import mathfor NaN/Infinity checkingfloattype that convertsNaNandInfinitytoNone(JSONnull)This follows the same pattern as pandas
to_json()which converts NaN to null by default.Testing
Previous Behavior
New Behavior
NaN and Infinity values are converted to
nullin JSON, allowing save/load to work correctly.Environment