Skip to content

OSS test fix #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbhandar2 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

OSS test fix #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cachelib/allocator/nvmcache/tests/NvmCacheTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,11 @@ TEST_F(NvmCacheTest, EvictToNvmGet) {
const auto nEvictions = this->evictionCount() - evictBefore;
ASSERT_LT(0, nEvictions);

// read from ram cache first so that we will not cause evictions
// Read from ram cache first so that we will not cause evictions
// to navy for items that are still in ram-cache until we start
// reading items from navy
// reading items from navy.
for (unsigned int i = nKeys + 100; i-- > 0;) {
unsigned int index = i - 1;
unsigned int index = i;
auto key = folly::sformat("key{}", index);
auto hdl = this->fetch(key, false /* ramOnly */);
hdl.wait();
Expand Down Expand Up @@ -248,6 +248,10 @@ TEST_F(NvmCacheTest, EvictToNvmGet) {
}
}

// Flush to ensure all async navy callbacks (including GetCtx destruction
// which decrements handle counts) have fully completed.
nvm.flushNvmCache();

// Reads are done. We should be at "0" active handle count across all threads.
ASSERT_EQ(0, nvm.getNumActiveHandles());
ASSERT_EQ(0, nvm.getHandleCountForThread());
Expand Down
Loading