gc2-es: Add sensor config table for VR#2674
Closed
Joseph-Shih-ww wants to merge 1 commit intofacebook:mainfrom
Closed
gc2-es: Add sensor config table for VR#2674Joseph-Shih-ww wants to merge 1 commit intofacebook:mainfrom
Joseph-Shih-ww wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D92956962. (Because this pull request was imported automatically, there will not be any future comments.) |
[Summary] Add modular VR sensor configuration tables and refine pre-read/write‑protect handling for ISL and XDPE VRs [Motivation] - Originally, the VR sensor readings at the BIC end did not distinguish between ISL and XDPE. - Different VRs have different default write-protect settings, leading to: VR sensor polling requires page switching, but XDPE's write-protect causes read/write conflicts. - Added XDPE pre/post hooks to safely handle write‑protect and page switching [Test Plane] 1. Verify that the VR sensor reading falls within the threshold range after 12V-cycle/sled cycle [Test Log] root@bmc-oob:/tmp# power-util server 12V-cycle 12V Power cycling fru 1... root@bmc-oob:/tmp# sensor-util server --threshold | grep VR MB_VR_VCCIN_TEMP_C (0xF) : 46.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA MB_VR_FIVRA_TEMP_C (0x10) : 41.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA MB_VR_EHV_TEMP_C (0x11) : 42.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA MB_VR_VCCD_TEMP_C (0x12) : 41.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA MB_VR_FAON_TEMP_C (0x13) : 43.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA MB_VR_VCCIN_VOLT_V (0x2A) : 1.760 Volts | (ok) | UCR: 1.930 | UNC: 1.910 | UNR: 2.200 | LCR: 1.460 | LNC: 1.480 | LNR: 0.400 MB_VR_FIVRA_VOLT_V (0x2B) : 1.800 Volts | (ok) | UCR: 1.920 | UNC: 1.900 | UNR: 2.200 | LCR: 1.690 | LNC: 1.710 | LNR: 0.400 MB_VR_EHV_VOLT_V (0x2C) : 1.790 Volts | (ok) | UCR: 1.900 | UNC: 1.880 | UNR: 2.200 | LCR: 1.700 | LNC: 1.720 | LNR: 0.400 MB_VR_VCCD_VOLT_V (0x2D) : 1.141 Volts | (ok) | UCR: 1.225 | UNC: 1.211 | UNR: 1.498 | LCR: 1.050 | LNC: 1.064 | LNR: 0.399 MB_VR_FAON_VOLT_V (0x2E) : 0.994 Volts | (ok) | UCR: 1.113 | UNC: 1.099 | UNR: 1.484 | LCR: 0.903 | LNC: 0.910 | LNR: 0.399 MB_VR_VCCIN_CURR_A (0x31) : 32.760 Amps | (ok) | UCR: 141.180 | UNC: 119.340 | UNR: 180.180 | LCR: NA | LNC: NA | LNR: NA MB_VR_FIVRA_CURR_A (0x32) : 3.720 Amps | (ok) | UCR: 53.010 | UNC: 48.050 | UNR: 70.990 | LCR: NA | LNC: NA | LNR: NA MB_VR_EHV_CURR_A (0x33) : 0.320 Amps | (ok) | UCR: 6.240 | UNC: 5.040 | UNR: 18.000 | LCR: NA | LNC: NA | LNR: NA MB_VR_VCCD_CURR_A (0x34) : 0.950 Amps | (ok) | UCR: 30.020 | UNC: 26.980 | UNR: 42.940 | LCR: NA | LNC: NA | LNR: NA MB_VR_FAON_CURR_A (0x35) : 8.580 Amps | (ok) | UCR: 46.020 | UNC: 42.120 | UNR: 60.060 | LCR: NA | LNC: NA | LNR: NA MB_VR_VCCIN_PWR_W (0x3A) : 57.810 Watts | (ok) | UCR: 253.800 | UNC: 214.320 | UNR: 324.300 | LCR: NA | LNC: NA | LNR: NA MB_VR_FIVRA_PWR_W (0x3C) : 6.840 Watts | (ok) | UCR: 95.190 | UNC: 86.640 | UNR: 127.680 | LCR: NA | LNC: NA | LNR: NA MB_VR_EHV_PWR_W (0x3D) : 0.608 Watts | (ok) | UCR: 11.248 | UNC: 8.968 | UNR: 32.376 | LCR: NA | LNC: NA | LNR: NA MB_VR_VCCD_PWR_W (0x3E) : 1.980 Watts | (ok) | UCR: 34.320 | UNC: 31.020 | UNR: 49.280 | LCR: NA | LNC: NA | LNR: NA MB_VR_FAON_PWR_W (0x3F) : 8.400 Watts | (ok) | UCR: 49.280 | UNC: 45.080 | UNR: 64.120 | LCR: NA | LNC: NA | LNR: NA MB_VR_DIMMA2_PMIC_PWR_W (0x40) : NA | (na) MB_VR_DIMMA3_PMIC_PWR_W (0x41) : NA | (na) MB_VR_DIMMA6_PMIC_PWR_W (0x42) : NA | (na) MB_VR_DIMMA7_PMIC_PWR_W (0x43) : NA | (na)
Vivy-Wang-ww
force-pushed
the
Vivy/fbgc_add_sensor_config_table
branch
from
e1f7b36 to
fb5f008
Compare
Contributor
|
@Joseph-Shih-ww has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
This pull request has been merged in 0a00f06. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Summary]
Related to Jira GC20T5T7-108
Add modular VR sensor configuration tables and refine pre-read/write‑protect handling for ISL and XDPE VRs
[Motivation]
[Test Plane]
[Test Log]
root@bmc-oob:/tmp# power-util server 12V-cycle
12V Power cycling fru 1...
root@bmc-oob:/tmp# sensor-util server --threshold | grep VR
MB_VR_VCCIN_TEMP_C (0xF) : 46.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA
MB_VR_FIVRA_TEMP_C (0x10) : 41.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA
MB_VR_EHV_TEMP_C (0x11) : 42.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA
MB_VR_VCCD_TEMP_C (0x12) : 41.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA
MB_VR_FAON_TEMP_C (0x13) : 43.000 C | (ok) | UCR: 100.000 | UNC: NA | UNR: 125.000 | LCR: NA | LNC: NA | LNR: NA
MB_VR_VCCIN_VOLT_V (0x2A) : 1.760 Volts | (ok) | UCR: 1.930 | UNC: 1.910 | UNR: 2.200 | LCR: 1.460 | LNC: 1.480 | LNR: 0.400
MB_VR_FIVRA_VOLT_V (0x2B) : 1.800 Volts | (ok) | UCR: 1.920 | UNC: 1.900 | UNR: 2.200 | LCR: 1.690 | LNC: 1.710 | LNR: 0.400
MB_VR_EHV_VOLT_V (0x2C) : 1.790 Volts | (ok) | UCR: 1.900 | UNC: 1.880 | UNR: 2.200 | LCR: 1.700 | LNC: 1.720 | LNR: 0.400
MB_VR_VCCD_VOLT_V (0x2D) : 1.141 Volts | (ok) | UCR: 1.225 | UNC: 1.211 | UNR: 1.498 | LCR: 1.050 | LNC: 1.064 | LNR: 0.399
MB_VR_FAON_VOLT_V (0x2E) : 0.994 Volts | (ok) | UCR: 1.113 | UNC: 1.099 | UNR: 1.484 | LCR: 0.903 | LNC: 0.910 | LNR: 0.399
MB_VR_VCCIN_CURR_A (0x31) : 32.760 Amps | (ok) | UCR: 141.180 | UNC: 119.340 | UNR: 180.180 | LCR: NA | LNC: NA | LNR: NA
MB_VR_FIVRA_CURR_A (0x32) : 3.720 Amps | (ok) | UCR: 53.010 | UNC: 48.050 | UNR: 70.990 | LCR: NA | LNC: NA | LNR: NA
MB_VR_EHV_CURR_A (0x33) : 0.320 Amps | (ok) | UCR: 6.240 | UNC: 5.040 | UNR: 18.000 | LCR: NA | LNC: NA | LNR: NA
MB_VR_VCCD_CURR_A (0x34) : 0.950 Amps | (ok) | UCR: 30.020 | UNC: 26.980 | UNR: 42.940 | LCR: NA | LNC: NA | LNR: NA
MB_VR_FAON_CURR_A (0x35) : 8.580 Amps | (ok) | UCR: 46.020 | UNC: 42.120 | UNR: 60.060 | LCR: NA | LNC: NA | LNR: NA
MB_VR_VCCIN_PWR_W (0x3A) : 57.810 Watts | (ok) | UCR: 253.800 | UNC: 214.320 | UNR: 324.300 | LCR: NA | LNC: NA | LNR: NA
MB_VR_FIVRA_PWR_W (0x3C) : 6.840 Watts | (ok) | UCR: 95.190 | UNC: 86.640 | UNR: 127.680 | LCR: NA | LNC: NA | LNR: NA
MB_VR_EHV_PWR_W (0x3D) : 0.608 Watts | (ok) | UCR: 11.248 | UNC: 8.968 | UNR: 32.376 | LCR: NA | LNC: NA | LNR: NA
MB_VR_VCCD_PWR_W (0x3E) : 1.980 Watts | (ok) | UCR: 34.320 | UNC: 31.020 | UNR: 49.280 | LCR: NA | LNC: NA | LNR: NA
MB_VR_FAON_PWR_W (0x3F) : 8.400 Watts | (ok) | UCR: 49.280 | UNC: 45.080 | UNR: 64.120 | LCR: NA | LNC: NA | LNR: NA
MB_VR_DIMMA2_PMIC_PWR_W (0x40) : NA | (na)
MB_VR_DIMMA3_PMIC_PWR_W (0x41) : NA | (na)
MB_VR_DIMMA6_PMIC_PWR_W (0x42) : NA | (na)
MB_VR_DIMMA7_PMIC_PWR_W (0x43) : NA | (na)