postinstall command put in package.json#17183
postinstall command put in package.json#17183hkwathome wants to merge 1 commit intofacebook:mainfrom
Conversation
postinstall command put in package.json , it executes shell script called postinstall to do backup as original package.json gets updated by npm audit fix --force and user may want to restore his original package.json . as project is independent of versioning from github. pl ignore my earlier patch - hkwathome-patch-1 , as that gave error and not working. this is tested with same modification to create-react-app new sample project, however react team can review the need to echo and take backup of package.json file postinstall.sh needs to be put in scripts folder in the project
|
Hi @hkwathome! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
postinstall command is added in package.json to excute scripts/postinstall.sh , it executes shell script called postinstall.sh to do backup as original package.json as npm audit fix --force updates the user written package.json and there is no backup of package.json currently done , Thus original package.json gets lost , unless the Project is git maintained , and npm audit fix --force can be reversed by developer , and user may want to restore his original package.json .
this creates a backup of original package.json at the time of "npm install" itself , this is tested with same modification to create-react-app new sample project, however react team can review the need to echo and take backup of package.json file postinstall.sh needs to be put in scripts folder in the project