Adapt sedlex-ppx AST generation for OCaml 5.4#9378
Open
filipeom wants to merge 2 commits intofacebook:mainfrom
Open
Adapt sedlex-ppx AST generation for OCaml 5.4#9378filipeom wants to merge 2 commits intofacebook:mainfrom
filipeom wants to merge 2 commits intofacebook:mainfrom
Conversation
Refactored `pexp_function` in sedlex-ppx to use the new 3-argument signature and `Pfunction_cases` required by ppxlib >= 0.37.0. The goal is to make flow compatible with the OCaml 5.4 compiler.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D97610327. (Because this pull request was imported automatically, there will not be any future comments.) |
Due to the update of `ppxlib` to 0.37.0 and the transitive dependencies of `ppx_expect`, the minimum OCaml compiler version needs to be bumped to 5.3.0. Consequently, js_of_ocaml also needs to be updated as it wouldn't compile with 5.3.0.
SamChou19815
requested changes
Mar 21, 2026
Contributor
SamChou19815
left a comment
SamChou19815
left a comment
There was a problem hiding this comment.
Unfortunately, this broke our internal buck2 build that's still stuck in the ocaml 5.2 toolchain, which we share with hhvm and it's not easy to upgrade internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
pexp_functionin sedlex-ppx to use the new 3-argument function andPfunction_casesrequired by ppxlib >= 0.37.0. The goal is to make flow compatible with the OCaml 5.4 compiler.EDIT: Due to the update of ppxlib to 0.37.0 and the transitive dependencies of ppx_expect, the minimum OCaml compiler version also needed to be bumped up to 5.3.0. Consequently, js_of_ocaml also needs to be updated as it wouldn't compile with ocaml 5.3.0. If this is not desired feel free to close this PR.