Add null check for ViewState in SurfaceMountingManager::updateProps#56147
Closed
bartlomiejbloniarz wants to merge 1 commit intomainfrom
Closed
Add null check for ViewState in SurfaceMountingManager::updateProps#56147bartlomiejbloniarz wants to merge 1 commit intomainfrom
bartlomiejbloniarz wants to merge 1 commit intomainfrom
Conversation
Summary: I saw that in D95793355 a null check was added for the view state in updateLayout. A similar issue can happen (and has been happening with Reanimated) with the updateProps method, so this diff makes it consistent with the other codepaths. ## Changelog: [General] [Changed] - use getNullableViewState in SurfaceMountingManager::updateProps and log a soft exception instead Differential Revision: D97087668
meta-cla
bot
added
the
CLA Signed
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97087668. |
facebook-github-tools
bot
added
p: Software Mansion
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in bbf7004 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in bbf7004. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I saw that in D95793355 a null check was added for the view state in updateLayout. A similar issue can happen (and has been happening with Reanimated) with the updateProps method, so this diff makes it consistent with the other codepaths.
Changelog:
[General] [Changed] - use getNullableViewState in SurfaceMountingManager::updateProps and log a soft exception instead
Differential Revision: D97087668