Skip to content

Add macOS 26 icon for RNDT (#56149) #56149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntie wants to merge 1 commit into
base: main
Choose a base branch
from
+120 −32
Open

Add macOS 26 icon for RNDT (#56149) #56149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ jobs:
run: yarn test-generated-typescript

build_debugger_shell:
runs-on: ubuntu-latest
runs-on: macos-26
needs: check_code_changes
if: needs.check_code_changes.outputs.debugger_shell == 'true'
steps:
Expand Down
2 changes: 1 addition & 1 deletion flow-typed/npm/electron-packager_v18.x.x.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ declare module '@electron/packager' {
};
extraResource?: string | string[];
helperBundleId?: string;
icon?: string;
icon?: string | string[];
ignore?: RegExp | (string | RegExp)[] | IgnoreFunction;
junk?: boolean;
name?: string;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@babel/plugin-transform-regenerator": "^7.24.7",
"@babel/preset-env": "^7.25.3",
"@babel/preset-flow": "^7.24.7",
"@electron/packager": "^18.3.6",
"@electron/packager": "^18.4.4",
"@expo/spawn-async": "^1.7.2",
"@jest/create-cache-key-function": "^29.7.0",
"@microsoft/api-extractor": "^7.52.2",
Expand Down
0 ...er-shell/src/electron/resources/icon.icns → ...tron/resources/React Native DevTools.icns
View file
Open in desktop
File renamed without changes.
12 changes: 12 additions & 0 deletions ...r-shell/src/electron/resources/React Native DevTools.icon/Assets/logo_light.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
41 changes: 41 additions & 0 deletions packages/debugger-shell/src/electron/resources/React Native DevTools.icon/icon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{
"fill" : {
"linear-gradient" : [
"display-p3:0.21574,0.21966,0.23974,1.00000",
"display-p3:0.13729,0.14116,0.15294,1.00000"
]
},
"groups" : [
{
"blur-material" : null,
"layers" : [
{
"glass" : false,
"image-name" : "logo_light.svg",
"name" : "logo_light",
"position" : {
"scale" : 1.37,
"translation-in-points" : [
0,
0
]
}
}
],
"shadow" : {
"kind" : "neutral",
"opacity" : 0.5
},
"specular" : true,
"translucency" : {
"enabled" : false,
"value" : 0.5
}
}
],
"supported-platforms" : {
"squares" : [
"macOS"
]
}
}
78 changes: 53 additions & 25 deletions scripts/debugger-shell/build-binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,28 @@ const PACKAGE_ROOT = path.join(
'packages',
'debugger-shell',
);
const ICON_BASE = path.join(PACKAGE_ROOT, 'src/electron/resources');

const platformConfigs = [
{
platform: ['darwin'],
arch: ['x64', 'arm64'],
icon: [
path.join(ICON_BASE, 'React Native DevTools.icns'),
path.join(ICON_BASE, 'React Native DevTools.icon'),
],
},
{
platform: ['win32'],
arch: ['x64', 'arm64'],
icon: path.join(ICON_BASE, 'icon.ico'),
},
{
platform: ['linux'],
arch: ['x64', 'arm64'],
icon: path.join(ICON_BASE, 'icon.png'),
},
];

async function main() {
const pkg = JSON.parse(
Expand Down Expand Up @@ -73,31 +95,37 @@ async function main() {

await writeBuildInfo();

await packager({
dir: PACKAGE_ROOT,
icon: path.join(PACKAGE_ROOT, 'src/electron/resources/icon'),
platform: ['win32', 'darwin', 'linux'],
arch: ['x64', 'arm64'],
name: APP_NAME,
appVersion: pkg.version,
appCopyright: COPYRIGHT,
appCategoryType: 'public.app-category.developer-tools',
asar: true,
appBundleId: APP_BUNDLE_IDENTIFIER,
out: path.join(PACKAGE_ROOT, 'build'),
win32metadata: {
CompanyName: COMPANY_NAME,
ProductName: APP_NAME,
InternalName: APP_NAME,
FileDescription: `${APP_NAME}.exe`,
OriginalFilename: `${APP_NAME}.exe`,
},
overwrite: true,
ignore: [
...IGNORE_PREFIXES.map(prefix => new RegExp('^' + escapeRegex(prefix))),
...IGNORE_FILES.map(file => new RegExp('^' + escapeRegex(file) + '$')),
],
});
await Promise.all(
platformConfigs.map(platformConfig =>
packager({
...platformConfig,
dir: PACKAGE_ROOT,
name: APP_NAME,
appVersion: pkg.version,
appCopyright: COPYRIGHT,
appCategoryType: 'public.app-category.developer-tools',
asar: true,
appBundleId: APP_BUNDLE_IDENTIFIER,
out: path.join(PACKAGE_ROOT, 'build'),
win32metadata: {
CompanyName: COMPANY_NAME,
ProductName: APP_NAME,
InternalName: APP_NAME,
FileDescription: `${APP_NAME}.exe`,
OriginalFilename: `${APP_NAME}.exe`,
},
overwrite: true,
ignore: [
...IGNORE_PREFIXES.map(
prefix => new RegExp('^' + escapeRegex(prefix)),
),
...IGNORE_FILES.map(
file => new RegExp('^' + escapeRegex(file) + '$'),
),
],
}),
),
);
}

async function writeBuildInfo() {
Expand Down
15 changes: 11 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,17 +1123,18 @@
minimist "^1.2.6"
plist "^3.0.5"

"@electron/packager@^18.3.6":
version "18.3.6"
resolved "https://registry.yarnpkg.com/@electron/packager/-/packager-18.3.6.tgz#3596399334866737bc33ab663e90376d7aad89e4"
integrity sha512-1eXHB5t+SQKvUiDpWGpvr90ZSSbXj+isrh3YbjCTjKT4bE4SQrKSBfukEAaBvp67+GXHFtCHjQgN9qSTFIge+Q==
"@electron/packager@^18.4.4":
version "18.4.4"
resolved "https://registry.yarnpkg.com/@electron/packager/-/packager-18.4.4.tgz#708458f73639c2aa919ce5f6250ac519fa53ee5c"
integrity sha512-fTUCmgL25WXTcFpM1M72VmFP8w3E4d+KNzWxmTDRpvwkfn/S206MAtM2cy0GF78KS9AwASMOUmlOIzCHeNxcGQ==
dependencies:
"@electron/asar" "^3.2.13"
"@electron/get" "^3.0.0"
"@electron/notarize" "^2.1.0"
"@electron/osx-sign" "^1.0.5"
"@electron/universal" "^2.0.1"
"@electron/windows-sign" "^1.0.0"
"@malept/cross-spawn-promise" "^2.0.0"
debug "^4.0.1"
extract-zip "^2.0.0"
filenamify "^4.1.0"
Expand All @@ -1143,6 +1144,7 @@
junk "^3.1.0"
parse-author "^2.0.0"
plist "^3.0.0"
prettier "^3.4.2"
resedit "^2.0.0"
resolve "^1.1.6"
semver "^7.1.3"
Expand Down Expand Up @@ -7832,6 +7834,11 @@ prettier@3.6.2:
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.6.2.tgz#ccda02a1003ebbb2bfda6f83a074978f608b9393"
integrity sha512-I7AIg5boAr5R0FFtJ6rCfD+LFsWHp81dolrFD8S79U9tb8Az2nGrJncnMSnys+bpQJfRUzqs9hnA81OAA3hCuQ==

prettier@^3.4.2:
version "3.8.1"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.8.1.tgz#edf48977cf991558f4fcbd8a3ba6015ba2a3a173"
integrity sha512-UOnG6LftzbdaHZcKoPFtOcCKztrQ57WkHDeRD9t/PTQtmT0NHSeWWepj6pS0z/N7+08BHFDQVUrfmfMRcZwbMg==

pretty-format@^29.0.0, pretty-format@^29.7.0:
version "29.7.0"
resolved "https://registry.yarnpkg.com/pretty-format/-/pretty-format-29.7.0.tgz#ca42c758310f365bfa71a0bda0a807160b776812"
Expand Down
Loading