Add TypedArray, UInt8Array in JSI (#56158)#56158
Open
tsaichien wants to merge 5 commits intofacebook:mainfrom
Open
Add TypedArray, UInt8Array in JSI (#56158)#56158tsaichien wants to merge 5 commits intofacebook:mainfrom
TypedArray, UInt8Array in JSI (#56158)#56158tsaichien wants to merge 5 commits intofacebook:mainfrom
Conversation
Summary: After reviewing the feasibility of adding new Runtime functionality, we realized the current state of `Runtime` makes it hard/inconvenient to add new basic functionality. It requires creating a new interface (e.g. `IRuntime2`) to declare the new APIs. Then, everywhere it is needed, both the original `Runtime` and `IRuntime2` needs to passed in to access both APIs. After discussion, we decided to introduce `IRuntime`, which will declare most of the `Runtime` functionalities. All "protected" APIs, which made sense before interfaces were introduced, will now be public. The protected static methods of `Runtime` will remain as is for the Friends to access. After we decided to cut "stable" (after incoming JSI improvements), new functionalities will be added in `IRuntime2` interface. `IRuntime2` will inherit `IRuntime` to make existing functionality easy to access. Differential Revision: D89093651
Summary: Currently, the size of a jsi `Array` is immutable. Once the `Array` is created, users can only set the element at an existing index, but not append to it. This change adds an `Array::push` API to improve ergonomics. Differential Revision: D82254334
Summary: Adds `ArrayBuffer::getMutableBuffer` to JSI. This allows the user to retrieve a `MutableBuffer` from the `ArrayBuffer`. The data referenced by the `MutableBuffer` will be alive during the entirety of the `MutableBuffer` lifespan. Addresses: facebook/hermes#1578 Differential Revision: D91264901
Differential Revision: D92993088
meta-cla
bot
added
the
CLA Signed
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95245175. |
meta-codesync
bot
changed the title
TypedArray, UInt8Array in JSITypedArray, UInt8Array in JSI (#56158)
tsaichien
force-pushed
the
export-D95245175
branch
from
526710c to
be37254
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 19, 2026
Summary: Pull Request resolved: facebook#56158 Add TypedArray and Uint8Array types to JSI with supporting APIs. New types: - `TypedArray`: Base class for all typed arrays - `Uint8Array`: Uint8Array type extending TypedArray New IRuntime APIs: - `getBuffer(TypedArray)`: Get underlying ArrayBuffer - `getByteOffset(TypedArray)`: Get byte offset property - `getByteLength(TypedArray)`: Get byte length property - `getLength(TypedArray)`: Get length property - `createUint8Array(size_t)`: Create Uint8Array with length - `createUint8Array(ArrayBuffer, offset, length)`: Create from ArrayBuffer - `isUint8Array(Object)`: Check if object is Uint8Array Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95245175
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Mar 19, 2026
Summary: Pull Request resolved: facebook#56158 Add TypedArray and Uint8Array types to JSI with supporting APIs. New types: - `TypedArray`: Base class for all typed arrays - `Uint8Array`: Uint8Array type extending TypedArray New IRuntime APIs: - `getBuffer(TypedArray)`: Get underlying ArrayBuffer - `getByteOffset(TypedArray)`: Get byte offset property - `getByteLength(TypedArray)`: Get byte length property - `getLength(TypedArray)`: Get length property - `createUint8Array(size_t)`: Create Uint8Array with length - `createUint8Array(ArrayBuffer, offset, length)`: Create from ArrayBuffer - `isUint8Array(Object)`: Check if object is Uint8Array Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95245175
tsaichien
force-pushed
the
export-D95245175
branch
from
be37254 to
fe0c6ae
Compare
Summary: Pull Request resolved: facebook#56158 Add TypedArray and Uint8Array types to JSI with supporting APIs. New types: - `TypedArray`: Base class for all typed arrays - `Uint8Array`: Uint8Array type extending TypedArray New IRuntime APIs: - `getBuffer(TypedArray)`: Get underlying ArrayBuffer - `getByteOffset(TypedArray)`: Get byte offset property - `getByteLength(TypedArray)`: Get byte length property - `getLength(TypedArray)`: Get length property - `createUint8Array(size_t)`: Create Uint8Array with length - `createUint8Array(ArrayBuffer, offset, length)`: Create from ArrayBuffer - `isUint8Array(Object)`: Check if object is Uint8Array Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D95245175
tsaichien
force-pushed
the
export-D95245175
branch
from
fe0c6ae to
ffb82f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add TypedArray and Uint8Array types to JSI with supporting APIs.
New types:
TypedArray: Base class for all typed arraysUint8Array: Uint8Array type extending TypedArrayNew IRuntime APIs:
getBuffer(TypedArray): Get underlying ArrayBuffergetByteOffset(TypedArray): Get byte offset propertygetByteLength(TypedArray): Get byte length propertygetLength(TypedArray): Get length propertycreateUint8Array(size_t): Create Uint8Array with lengthcreateUint8Array(ArrayBuffer, offset, length): Create fromArrayBuffer
isUint8Array(Object): Check if object is Uint8ArrayChangelog: [Internal]
Reviewed By: lavenzg
Differential Revision: D95245175