[DevTools] Fix: Trace Updates incorrectly highlights components when filtered parent re-mounts them#35618
Open
youaresoyoung wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
…iltered parent re-mounts them
youaresoyoung
changed the title
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
Bot
added
the
Resolution: Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug:
When "Hide DOM nodes" filter is enabled, updating a sibling component incorrectly highlights unrelated components that share a filtered parent.
Root Cause:
didFiberRender()only checks thePerformedWorkflag but doesn't verify if the fiber is a mount vs update. When DevTools re-mounts components after their filtered parent changes, they havePerformedWork=true+alternate=nullcausing them to be incorrectly marked as "rendered".Fix:
Add
alternatecheck indidFiberRender(). Ifalternate === null, the fiber is a mount (not an update) and should not be highlighted in trace updates.Before
before.mov
After
after.mov