fix(eslint-plugin-react-hooks): stabilize flat config typing and binding#36118
Open
mrsandy1965 wants to merge 2 commits intofacebook:mainfrom
Open
fix(eslint-plugin-react-hooks): stabilize flat config typing and binding#36118mrsandy1965 wants to merge 2 commits intofacebook:mainfrom
mrsandy1965 wants to merge 2 commits intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
eslint-plugin-react-hooksflat config typing used a cast + late mutation pattern ({} as ...+Object.assign), which can weaken strict TypeScript inference and was tied to reports of flat config typing friction.Also, the flat config getters returned newly allocated objects on every access.
Solution
Refactored flat config construction to be strongly typed and circular-reference-safe without
Object.assign, then memoized getter results to avoid repeated allocations.Changes made
ReactHooksPlugin/ flat config types for safer typing.configs.flatcast-and-assign initialization with typed getters.'react-hooks'.recommendedrecommended-latestso each object is created once and reused.
Testing performed
yarn prettieryarn linccd packages/eslint-plugin-react-hooks && yarn test --silent --no-watchmanResult: all package tests pass (5 suites, 5083 tests).