Add bindings for mysql_{library,thread}_{init,end} functions#75
Open
codemage wants to merge 2 commits intofarcepest:masterfrom
Open
Add bindings for mysql_{library,thread}_{init,end} functions#75codemage wants to merge 2 commits intofarcepest:masterfrom
codemage wants to merge 2 commits intofarcepest:masterfrom
Conversation
added 2 commits
June 20, 2014 11:15
This extracts _mysql_SetError and _mysql_SetErrorString functions from _mysql_Exception, making the code a bit less repetetive and allowing them to be used later to raise other types of exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows clients to fix potential memory leaks discussed in http://sourceforge.net/p/mysql-python/bugs/177/
mysql_thread_end() is the important thing, but this change goes ahead and modernizes the docstrings and bindings for mysql_server_init/mysql_server_end to note that the mysql_server_* names are deprecated and offer mysql_library_* versions.