Conversation
- Split `_list_impl` into `_list_sync` and `_list_async` in `ListEndpointMixin`. - Split `_get_impl` and `_get_impl_path` into explicit sync/async variants in `FilterGetEndpointMixin` and `PathGetEndpointMixin`. - Update `GenericEndpoint` to support strict client typing via `_require_sync_client` and `_require_async_client`. - Remove runtime type checking (`isawaitable`, `is_async` flags) from core endpoint logic. - Update unit tests to mock specific sync/async implementation methods. This change improves strict typing, reduces cognitive load, and eliminates implicit control flow in favor of explicit method dispatch. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
fderuiter
deleted the
refactor/explicit-sync-async-mixins-6718542356546304512
branch
1 participant
Refactored
ListEndpointMixin,FilterGetEndpointMixin, andPathGetEndpointMixinto use explicit_syncand_asyncmethods instead of relying on runtime type inspection andis_asyncflags. UpdatedGenericEndpointto enforce strict typing for client access. This aligns with the "Explicit > Implicit" and "Sync/Async Parity" architectural principles. All unit tests were updated to reflect the new internal method names.PR created automatically by Jules for task 6718542356546304512 started by @fderuiter