Conversation
- Removed `_create_impl` from `RecordsEndpoint` to eliminate boolean flag argument smell. - Updated `create` and `async_create` to call `_prepare_create_request` and the appropriate sync/async execution method directly. - Removed unused `_get_client` helper from `GenericEndpoint`. - Maintained strict typing and sync/async parity. - Verified with existing tests. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
fderuiter
deleted the
refactor/records-explicit-async-12808461933828327089
branch
1 participant
Refactored
RecordsEndpointto remove the_create_implmethod which used a boolean flag to switch between sync and async execution. This change makes the code more explicit and type-safe by havingcreateandasync_createcall the specific execution methods directly. Also cleaned up theGenericEndpointby removing the unused_get_clienthelper. This aligns with the "Architect" manifesto principles of Explicit > Implicit and KISS.PR created automatically by Jules for task 12808461933828327089 started by @fderuiter