Conversation
6ac6044 to
ceced02
Compare
ceced02 to
ddc5b6f
Compare
|
I'm converting the remaining chapters in this PR to keeps things together. |
|
@luizbonino and @dennisvang, i'm looking for feedback on setup, naming, and what we're missing out on look and feel. |
|
Hi @kburger, looks good already. :) Not done reviewing, but some notes for now:
|
* add .gitignore * add minimal pyproject.toml with bikeshed dev dependency * add uv.lock (showing a preference for using astral-sh/uv to manage python and packages)
|
@dennisvang bikeshed support commonmark, which does not include tables (see speced/bikeshed#2857 and speced/bikeshed#1128). When a markdown table is written once, and read many times I agree, but if a table needs frequent updates the maintenance of a markdown table can be cumbersome. For the conformance section, I think it can be influences by configuration settings. That would be something to investigate. |
Thanks for pointing that out. I was not aware that md tables are not supported.
Yes you're right. |
There was a problem hiding this comment.
@kburger (and @luizbonino) This looks good, but I've made some minor suggestions in the review comments, e.g. line breaks etc.
In addition, I've moved the html tables from the metadata.md markdown file into separate html files (already committed in 8e15ff0).
I've also compared all new content with that from the original v1.2 html file, word for word. This includes the text from the new markdown files, as well as the RDF from the new ttl files and the tables from the new html files.
(and confirmed that they are indeed identical)
Finally, I've suggested some minor changes to stay as close as possible to the original content, like adding the [RDF] reference and restoring section 1.2.
There's one important decision to be made, regarding the type of publication. See the this comment for details.
| <pre class=metadata> | ||
| Title: FAIR Data Point | ||
| Shortname: fdp | ||
| Status: LS |
There was a problem hiding this comment.
@luizbonino, @kburger Should the spec be a draft W3C Community Group Report published by the W3C FDP community group?
That would be:
| Status: LS | |
| Org: W3C | |
| Group: fdpcg | |
| Status: CG-DRAFT | |
| Level: none | |
| ED: https://specs.fairdatapoint.org/ |
Also see CG-DRAFT.
UPDATE: I've created speced/bikeshed-boilerplate#193 to register the FDP Community Group as fdpcg.
There was a problem hiding this comment.
Suggestion: use for now the unoficcial specification and use the CG-DRAFT when we start working on v2. Then we need to communicate it with the FDP CG.
| The FDP extends the DCAT model by adding the concept of a `FAIRDataPoint` as a specific type of data service that serves metadata catalogs and metadata records. | ||
| The DCAT extensions and other FDP-specific concepts and relations are defined in the FDP ontology (using the namespace prefix `fdp-o`). | ||
| In the FDP ontology, the FAIR Data Point is represented by a sub-class of the concept of `MetadataService`. | ||
| Figure 4.1 only depicts the properties that are not already inherited from `Data Service` and `Resource`. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
@kburger @luizbonino Personally I would prefer a (more) flat file structure as follows:
What do you think? |
Co-authored-by: Dennis <29799340+dennisvang@users.noreply.github.com>
Co-authored-by: Dennis <29799340+dennisvang@users.noreply.github.com>
Co-authored-by: Dennis <29799340+dennisvang@users.noreply.github.com>
Co-authored-by: Dennis <29799340+dennisvang@users.noreply.github.com>
Co-authored-by: Dennis <29799340+dennisvang@users.noreply.github.com>
| <pre class=metadata> | ||
| Title: FAIR Data Point | ||
| Shortname: fdp | ||
| Status: LS |
Co-authored-by: Dennis <29799340+dennisvang@users.noreply.github.com>
* add github build-validate workflow, using the w3c/spec-prod action * run workflow on pull request and on push to development branch * prevent duplicate workflows
* move markdown files from subdirs into src/ and update index.bs accordingly * move src/metadata/tables/ to src/tables/ and update refs * rename src/metadata/ to src/rdf/ and update refs * fix img tags
* update index.html with bikeshed build * remove duplicate image and unused images * remove deprecated style/, scripts/, images/_notes/ * remove deprecated spec.md * create standalone copies of old versions in separate directories (Basically we just create snapshots of the old versions of the spec, including all relevant resources, in separate directories. This introduces some duplication of resources (images, style, scripts), but it makes each version self-contained. A DRY approach using git history will be considered at a later stage.) * adapt all links to new file structure and make image links relative to enable simple snapshot copy
Added an
index.bsscaffold to demonstrate the use of bikeshed. Locally this can be run using:Note that the output is not on par with the existing
index.html, because bikeshed is opinionated. With some css we can probably get closer, but that is out of scope for this PR.Up for discussion:
.mdfile naming)todo:
src/(see comment) (done in Flatten the directory structure for src/ #25)fixes #19 (?)