test: fix vitest vi.mock hoisting warnings and my-timezone resolution#1156
Merged
test: fix vitest vi.mock hoisting warnings and my-timezone resolution#1156
Conversation
Move vi.mock calls to the top level in ntpclient and jszip-cli tests to comply with vitest's module hoisting requirements. Add a vitest.config.ts for my-timezone to resolve the ntpclient workspace package from source, fixing test failures when ntpclient has not been built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vi.mock('node:dgram')to the top level inntpclient/src/index.test.ts(was nested insidebeforeEach, triggering a vitest hoisting warning)vi.mock('fs')andvi.mock('glob')to the top level injszip-cli/src/BuildService.test.ts(were nested insidebeforeAll, triggering vitest hoisting warnings)packages/my-timezone/vitest.config.tswith a resolve alias forntpclientpointing to its source, fixing a test failure when thentpclientpackage has not been built yetTest plan
yarn testpasses with no vitest mock hoisting warningsmy-timezonetests pass without requiring a prioryarn build:ts