fix(my-timezone): clarify solar time semantics and fix stale API names#1158
Merged
fix(my-timezone): clarify solar time semantics and fix stale API names#1158
Conversation
…s in docs - Reword README and package description to make clear this calculates local mean time (solar time), not political timezone data - Fix stale method names in README examples (getTimeByAddress → getDateByAddress, getTimeByLocation → getDateByLongitude) - Add deterministic offset tests using fake timers that verify the core solar-time math (0°=UTC, ±90°=±6h, ±180°=±12h, 1°=4min)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2026
## my-timezone [1.15.2](https://github.com/ffflorian/node-packages/compare/my-timezone@1.15.1...my-timezone@1.15.2) (2026-03-28) ### Bug Fixes * **my-timezone:** clarify solar time semantics and fix stale API names ([#1158](#1158)) ([828c91b](828c91b))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsondescription to make clear the package calculates local mean time (solar time based on longitude), not political timezone data (UTC offsets, DST, etc.)getTimeByAddress→getDateByAddress,getTimeByLocation→getDateByLongitude)vi.useFakeTimers()that verify the core math: 0°=UTC, ±90°=±6h, ±180°=±12h, and that each degree equals exactly 4 minutes of offsetTest plan
yarn workspace my-timezone testpasses (9 tests)