chore(ntpclient): resolve TypeScript module errors without requiring a build#1159
Merged
chore(ntpclient): resolve TypeScript module errors without requiring a build#1159
Conversation
…pt resolution Without a built dist/, TypeScript could not find type declarations when resolving the ntpclient module. Adding a types condition in the exports map pointing to src/index.ts allows TypeScript to resolve types directly from source without requiring a prior build step.
ffflorian
changed the title
ffflorian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportsfield to include atypescondition pointing tosrc/index.ts, so TypeScript can resolve types from source without needing a priordist/buildvitest.config.tsfrom TypeScript compilation intsconfig.jsonTest plan
Cannot find module 'ntpclient'TypeScript error is gone inmy-timezone/src/MyTimezone.tswithout buildingntpclientfirstyarn build:tsand confirm both packages compile successfullyyarn testand confirm tests pass