feat: Add GENERICSYSTEMEVENT support to RealTimeEvent enum and RealTimeEventListener#384
Open
Alex-Nalin wants to merge 2 commits intofinos:mainfrom
Open
feat: Add GENERICSYSTEMEVENT support to RealTimeEvent enum and RealTimeEventListener#384Alex-Nalin wants to merge 2 commits intofinos:mainfrom
Alex-Nalin wants to merge 2 commits intofinos:mainfrom
Conversation
…meEventListener Closes finos#383 ## What Adds native dispatch support for `GENERICSYSTEMEVENT` events received via the Symphony datahose. ## Why BDK 2.11.2 silently drops `GENERICSYSTEMEVENT` with "Received event with an unknown type" because the event is not registered in the `RealTimeEvent` enum. Bot developers who subscribe to this event type via `datahose.eventTypes` cannot handle it at all without monkey-patching the BDK internals. ## Changes - `abstract_datafeed_loop.py`: add `GENERICSYSTEMEVENT` to `RealTimeEvent` enum - `real_time_event_listener.py`: add `on_generic_system_event` no-op + import The generated models (`V4GenericSystemEvent`, `V4Payload.generic_system_event`) already exist — no gen/ changes required. ## Testing Verified end-to-end by subscribing to `GENERICSYSTEMEVENT` via `POST /agent/v5/events/read` and confirming `on_generic_system_event` is called on the listener with the correct `V4GenericSystemEvent` payload.
…meEventListener Closes finos#383 ## What Adds native dispatch support for `GENERICSYSTEMEVENT` events received via the Symphony datahose. ## Why BDK 2.11.2 silently drops `GENERICSYSTEMEVENT` with "Received event with an unknown type" because the event is not registered in the `RealTimeEvent` enum. Bot developers who subscribe to this event type via `datahose.eventTypes` cannot handle it at all without monkey-patching the BDK internals. ## Changes - `abstract_datafeed_loop.py`: add `GENERICSYSTEMEVENT` to `RealTimeEvent` enum - `real_time_event_listener.py`: add `on_generic_system_event` no-op + import The generated models (`V4GenericSystemEvent`, `V4Payload.generic_system_event`) already exist — no gen/ changes required. ## Testing Verified end-to-end by subscribing to `GENERICSYSTEMEVENT` via `POST /agent/v5/events/read` and confirming `on_generic_system_event` is called on the listener with the correct `V4GenericSystemEvent` payload. Use test_handle_generic_system_event ## Example/Sample code An example specifically for handling `GENERICSYSTEMEVENT` can be found https://github.com/finos/symphony-bdk-python/tree/main/examples/datafeed/datahose_generic_system_event.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #383
What
Adds native dispatch support for
GENERICSYSTEMEVENTevents received via the Symphony datahose.Why
BDK 2.11.2 silently drops
GENERICSYSTEMEVENTwith "Received event with anunknown type" because the event is not registered in the
RealTimeEventenum.Bot developers who subscribe to this event type via
datahose.eventTypescannot handle it at all without monkey-patching the BDK internals.Changes
abstract_datafeed_loop.py: addGENERICSYSTEMEVENTtoRealTimeEventenumreal_time_event_listener.py: addon_generic_system_eventno-op + importThe generated models (
V4GenericSystemEvent,V4Payload.generic_system_event) already exist — no gen/ changes required.Testing
Verified end-to-end by subscribing to
GENERICSYSTEMEVENTviaPOST /agent/v5/events/readand confirmingon_generic_system_eventis called on the listener with the correctV4GenericSystemEventpayload. Use test_handle_generic_system_eventExample/Sample code
An example specifically for handling
GENERICSYSTEMEVENTcan be found https://github.com/finos/symphony-bdk-python/tree/main/examples/datafeed/datahose_generic_system_event.py