Conversation
…inquirer, generate-schema, lodash)
…nge-tracker-dependencies chore(firestore-bigquerychange-tracker): cleanup dependencies
sync next with master
Adding --provenance flag
Updating to a newer version of node
Change repository.url
…extension version Updates functions to use @firebaseextensions/firestore-bigquery-change-tracker v2 and increments the extension release version to 0.2.11 with corresponding changelog notes. Made-with: Cursor
…tracker bump Updates functions/package-lock.json for @firebaseextensions/firestore-bigquery-change-tracker@2.0.0 and normalizes LOG_LEVEL to the stricter tracker config type required during build. Made-with: Cursor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers updates across two Firebase extensions. The Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces updates for two extensions, firestore-bigquery-export and firestore-send-email.
For firestore-bigquery-export, the version is updated to 0.2.11, primarily to upgrade the firestore-bigquery-change-tracker dependency to v2. This change also cleans up the project by removing several unused dependencies. A new function for normalizing log levels has been added, and I've provided a suggestion to make it more robust.
For firestore-send-email, the version is bumped to 0.2.7, adding support for customArgs and ipPoolName in SendGrid options. This is a valuable feature enhancement, and the implementation, including new tests and documentation, appears to be thorough and correct.
| case "silent": | ||
| return "silent"; | ||
| default: | ||
| return LogLevel.INFO; |
There was a problem hiding this comment.
The normalizeLogLevel function is defined to return the TrackerLogLevel type, which is a union of string literals. While LogLevel.INFO from the @firebaseextensions/firestore-bigquery-change-tracker dependency likely corresponds to the string "info", it's safer and more consistent with the other cases in the switch statement to return the string literal directly. This change will make the function more robust against potential changes in the dependency.
| return LogLevel.INFO; | |
| return "info"; |
…packed files Publish nested partitioning files in the package tarball so BigQuery export can resolve runtime imports when testing this RC. Made-with: Cursor
… test linking The prerelease version 2.0.1-rc.0 does not satisfy downstream ^2.0.0 ranges, which can make CI resolve the published 2.0.0 package instead of the local workspace package. Made-with: Cursor
…ude nested build artifacts
7 participants
No description provided.