chore(firestore-bigquery-change-tracker): bump to 2.0.1-rc.0 and include nested build artifacts#2693
Conversation
…packed files Publish nested partitioning files in the package tarball so BigQuery export can resolve runtime imports when testing this RC. Made-with: Cursor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical packaging issue in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where nested files were not being included in the published npm package by updating the files glob in package.json. The version is also bumped to 2.0.1-rc.0. The change is sound, and I've added one suggestion to further simplify the files configuration for improved maintainability.
| "files": [ | ||
| "lib/*.js", | ||
| "lib/bigquery/*.js", | ||
| "lib/*.d.ts", | ||
| "lib/bigquery/*.d.ts" | ||
| "lib/**/*.js", | ||
| "lib/**/*.d.ts" | ||
| ], |
There was a problem hiding this comment.
For better maintainability, you can simplify the files array. Instead of listing glob patterns for specific file types, you can just include the entire lib directory. Since lib is a build output directory that is cleaned before each build, this is safe and more robust. It will automatically include any new file types that might be added to the build output in the future, such as source maps.
"files": [
"lib"
],… test linking The prerelease version 2.0.1-rc.0 does not satisfy downstream ^2.0.0 ranges, which can make CI resolve the published 2.0.0 package instead of the local workspace package. Made-with: Cursor
3 participants
Summary
@firebaseextensions/firestore-bigquery-change-trackerto2.0.1-rc.0for testinglib/**lib/bigquery/partitioning/*files are published so runtime imports resolve in downstream consumersWhy
2.0.0can fail at runtime with:Cannot find module './partitioning'because the package
filesglobs only included one level underlib/bigquery/*, excluding nested partitioning modules.Changes
firestore-bigquery-export/firestore-bigquery-change-tracker/package.json2.0.0->2.0.1-rc.0files:lib/*.jslib/bigquery/*.jslib/*.d.tslib/bigquery/*.d.tslib/**/*.jslib/**/*.d.tsfirestore-bigquery-export/firestore-bigquery-change-tracker/package-lock.json2.0.1-rc.0Test plan
npm run buildinfirestore-bigquery-export/firestore-bigquery-change-trackernpm pack --dry-runlib/bigquery/partitioning/index.jslib/bigquery/partitioning/config.js2.0.1-rc.0and validate downstream BigQuery extension install/test flow