Skip to content

Remove @hidden from GraphqlServerOptions and FirebaseContext #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
egilmorez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove @hidden from GraphqlServerOptions and FirebaseContext #1812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/v2/providers/dataconnect/graphql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ export function onGraphRequest(opts: GraphqlServerOptions): HttpsFunction {
}

/**
* @hidden
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing @hidden here exposes GraphqlServerOptions, but its resolvers property is of type GraphqlResolvers, which is still marked as @hidden (line 152). For complete documentation, consider making GraphqlResolvers public as well.

* Options for configuring the GraphQL server.
*/
export interface GraphqlServerOptions extends Omit<HttpsOptions, "cors"> {
Expand All @@ -140,7 +139,6 @@ export interface GraphqlServerOptions extends Omit<HttpsOptions, "cors"> {
}

/**
* @hidden
* Per-request context state shared by all resolvers in a particular query.
*/
export interface FirebaseContext {
Expand Down
Loading