Skip to content

Addresses v1->v2 issues with emoji#1834

Open
brittanycho wants to merge 2 commits intomasterfrom
emoji-issue
Open

Addresses v1->v2 issues with emoji#1834
brittanycho wants to merge 2 commits intomasterfrom
emoji-issue

Conversation

@brittanycho
Copy link

@brittanycho brittanycho commented Mar 18, 2026

Addresses v1->v2 issues with emoji

Further context:
A user reported an issue where emojis in Firebase Realtime Database triggers appear as gibberish characters in Cloud Functions V2, while working correctly in V1 functions. The emojis display correctly when queried directly from the database and on the frontend. The user wants to avoid maintaining separate database schemas for V1 and V2 compatibility.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the PathPattern utility to correctly and safely handle URL-encoded characters within path parameters. By introducing a new decoding function and integrating it into the parameter extraction logic, the system can now accurately interpret paths containing special characters, such as emojis, while also preventing crashes from malformed URI sequences. This improves the robustness and reliability of path matching for diverse inputs.

Highlights

  • New Utility Function: Introduced tryDecodeURIComponent to safely decode URI components, gracefully handling malformed inputs without throwing errors.
  • Path Parameter Decoding: Updated the PathPattern class to use tryDecodeURIComponent when extracting single and multi-capture path parameters, ensuring URL-encoded characters (like emojis) are correctly decoded.
  • Improved Test Coverage: Added new test cases to verify the correct decoding of URL-encoded parameters, including those containing emojis, and to confirm robust handling of malformed URI components.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for URL-encoded characters, like emojis, in path patterns. The implementation introduces a tryDecodeURIComponent utility function to safely decode path segments and applies it during match extraction. The changes are accompanied by new tests that cover both successful decoding and handling of malformed URI components. My review found one area for improvement in the new tryDecodeURIComponent function to make the error handling more robust. Overall, the changes are well-implemented and address the issue effectively.

Copy link
Contributor

@shettyvarun268 shettyvarun268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants