Conversation
google-oss-bot
requested review from
a team,
NhienLam,
Xiaoshouzi-gh,
aashishpatil-g,
avolkovi,
dconeybe,
erikeldridge,
hsubox76,
lisajian,
maneesht,
mansisampat,
pashanka,
sam-gc,
stephenarosaj,
tonyjhuang,
visumickey,
yoyomyo and
zwu52
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Vertex AI Mock Responses Check
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by the Changesets release action, updates versions across various Firebase JavaScript SDK packages. It introduces new AI capabilities, expands Firestore's query functionality with array expressions, and includes a significant beta API breaking change in Firestore's Pipelines API. Additionally, several internal utility functions were refined, and all affected packages had their dependencies updated to align with the latest improvements. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated by the Changesets release action, updates package versions and changelogs. The changes appear to be correct and consistent with an automated release process. My review focuses on improving the clarity of the generated changelogs by removing internal-facing notes that are not relevant for public release notes.
|
|
||
| ### Minor Changes | ||
|
|
||
| - [`843a8d7`](https://github.com/firebase/firebase-js-sdk/commit/843a8d7892beb27e6bb62bb6331fe03aef97c57e) [#9693](https://github.com/firebase/firebase-js-sdk/pull/9693) (fixes [#9625](https://github.com/firebase/firebase-js-sdk/issues/9625)) - Added `responseJsonSchema` to `GenerationConfig`. |
There was a problem hiding this comment.
The release note includes (fixes #9625). While this is useful for developers, it might be better to describe the fix in user-facing terms or omit the issue number for a cleaner public changelog.
|
|
||
| ### Patch Changes | ||
|
|
||
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) |
There was a problem hiding this comment.
The note (No release note needed.) appears to be an internal comment. For a public-facing changelog, it's best to remove such notes to maintain clarity and a professional tone.
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) | |
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. |
|
|
||
| ### Minor Changes | ||
|
|
||
| - [`9d33dd6`](https://github.com/firebase/firebase-js-sdk/commit/9d33dd6434dfc70cf835d603c1da09d9663885ec) [#9614](https://github.com/firebase/firebase-js-sdk/pull/9614) - Add validateArgsWithOptions() to Data Connect (internal change, no need to add to public release notes). |
There was a problem hiding this comment.
The note (internal change, no need to add to public release notes) seems like an internal comment. It should be removed from the public changelog to improve clarity for users.
| - [`9d33dd6`](https://github.com/firebase/firebase-js-sdk/commit/9d33dd6434dfc70cf835d603c1da09d9663885ec) [#9614](https://github.com/firebase/firebase-js-sdk/pull/9614) - Add validateArgsWithOptions() to Data Connect (internal change, no need to add to public release notes). | |
| - [`9d33dd6`](https://github.com/firebase/firebase-js-sdk/commit/9d33dd6434dfc70cf835d603c1da09d9663885ec) [#9614](https://github.com/firebase/firebase-js-sdk/pull/9614) - Add validateArgsWithOptions() to Data Connect. |
|
|
||
| ### Patch Changes | ||
|
|
||
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) |
There was a problem hiding this comment.
The note (No release note needed.) appears to be an internal comment. For a public-facing changelog, it's best to remove such notes to maintain clarity and a professional tone.
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) | |
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. |
|
|
||
| ### Patch Changes | ||
|
|
||
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) |
There was a problem hiding this comment.
The note (No release note needed.) appears to be an internal comment. For a public-facing changelog, it's best to remove such notes to maintain clarity and a professional tone.
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) | |
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. |
|
|
||
| - [`9d33dd6`](https://github.com/firebase/firebase-js-sdk/commit/9d33dd6434dfc70cf835d603c1da09d9663885ec) [#9614](https://github.com/firebase/firebase-js-sdk/pull/9614) - Add validateArgsWithOptions() to Data Connect (internal change, no need to add to public release notes). | ||
|
|
||
| - [`843a8d7`](https://github.com/firebase/firebase-js-sdk/commit/843a8d7892beb27e6bb62bb6331fe03aef97c57e) [#9693](https://github.com/firebase/firebase-js-sdk/pull/9693) (fixes [#9625](https://github.com/firebase/firebase-js-sdk/issues/9625)) - Added `responseJsonSchema` to `GenerationConfig`. |
There was a problem hiding this comment.
The release note includes (fixes #9625). While this is useful for developers, it might be better to describe the fix in user-facing terms or omit the issue number for a cleaner public changelog.
|
|
||
| - [`a383770`](https://github.com/firebase/firebase-js-sdk/commit/a3837700877822acd1bad82431a051d64f479508) [#9622](https://github.com/firebase/firebase-js-sdk/pull/9622) - Fixed X is not a function issues observed in server side rendering APIs. | ||
|
|
||
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) |
There was a problem hiding this comment.
The note (No release note needed.) appears to be an internal comment. For a public-facing changelog, it's best to remove such notes to maintain clarity and a professional tone.
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) | |
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. |
|
|
||
| ### Patch Changes | ||
|
|
||
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) |
There was a problem hiding this comment.
The note (No release note needed.) appears to be an internal comment. For a public-facing changelog, it's best to remove such notes to maintain clarity and a professional tone.
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) | |
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. |
|
|
||
| ### Patch Changes | ||
|
|
||
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) |
There was a problem hiding this comment.
The note (No release note needed.) appears to be an internal comment. For a public-facing changelog, it's best to remove such notes to maintain clarity and a professional tone.
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) | |
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. |
|
|
||
| ### Minor Changes | ||
|
|
||
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) |
There was a problem hiding this comment.
The note (No release note needed.) appears to be an internal comment. For a public-facing changelog, it's best to remove such notes to maintain clarity and a professional tone.
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. (No release note needed.) | |
| - [`2f7f426`](https://github.com/firebase/firebase-js-sdk/commit/2f7f426dec37efd75bad8dcc87cdd769ed4f7752) [#9608](https://github.com/firebase/firebase-js-sdk/pull/9608) - Remove `updateEmulatorBanner()`. |
1 participant
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to release, this PR will be updated.
Releases
@firebase/ai@2.10.0
Minor Changes
843a8d7#9693 (fixes #9625) - AddedresponseJsonSchematoGenerationConfig.Patch Changes
2f7f426]:@firebase/data-connect@0.5.0
Minor Changes
9d33dd6#9614 - Add validateArgsWithOptions() to Data Connect (internal change, no need to add to public release notes).Patch Changes
2f7f426#9608 - RemoveupdateEmulatorBanner(). (No release note needed.)Updated dependencies [
2f7f426]:firebase@12.11.0
Minor Changes
9d33dd6#9614 - Add validateArgsWithOptions() to Data Connect (internal change, no need to add to public release notes).843a8d7#9693 (fixes #9625) - AddedresponseJsonSchematoGenerationConfig.78384d3#9492 - Add support for array expressionsarrayFirst,arrayFirstN,arrayLast,arrayLastN,arrayMinimum,arrayMinimumN,arrayMaximum,arrayMaximumN,arrayIndexOf,arrayLastIndexOfandarrayIndexOfAllPatch Changes
54ff05e,9d33dd6,843a8d7,a383770,78384d3,2f7f426]:@firebase/firestore@4.13.0
Minor Changes
78384d3#9492 - Add support for array expressionsarrayFirst,arrayFirstN,arrayLast,arrayLastN,arrayMinimum,arrayMinimumN,arrayMaximum,arrayMaximumN,arrayIndexOf,arrayLastIndexOfandarrayIndexOfAllPatch Changes
54ff05e#9715 - Beta API Breaking change: Defer pipeline user data validation from initialization toexecute(). This breaking change is allowed in a non-major release since the Firestore Pipelines API is currently in Public Preview.a383770#9622 - Fixed X is not a function issues observed in server side rendering APIs.2f7f426#9608 - RemoveupdateEmulatorBanner(). (No release note needed.)Updated dependencies [
2f7f426]:@firebase/util@1.15.0
Minor Changes
2f7f426#9608 - RemoveupdateEmulatorBanner(). (No release note needed.)@firebase/analytics@0.10.21
Patch Changes
2f7f426]:@firebase/analytics-compat@0.2.27
Patch Changes
2f7f426]:@firebase/app@0.14.10
Patch Changes
Update SDK_VERSION.
Updated dependencies [
2f7f426]:@firebase/app-check@0.11.2
Patch Changes
2f7f426]:@firebase/app-check-compat@0.4.2
Patch Changes
2f7f426]:@firebase/app-compat@0.5.10
Patch Changes
2f7f426]:@firebase/auth@1.12.2
Patch Changes
2f7f426#9608 - RemoveupdateEmulatorBanner(). (No release note needed.)Updated dependencies [
2f7f426]:@firebase/auth-compat@0.6.4
Patch Changes
2f7f426]:@firebase/component@0.7.2
Patch Changes
2f7f426]:@firebase/database@1.1.2
Patch Changes
2f7f426#9608 - RemoveupdateEmulatorBanner(). (No release note needed.)Updated dependencies [
2f7f426]:@firebase/database-compat@2.1.2
Patch Changes
2f7f426]:@firebase/database-types@1.0.18
Patch Changes
2f7f426]:@firebase/firestore-compat@0.4.7
Patch Changes
54ff05e,a383770,78384d3,2f7f426]:@firebase/functions@0.13.3
Patch Changes
2f7f426#9608 - RemoveupdateEmulatorBanner(). (No release note needed.)Updated dependencies [
2f7f426]:@firebase/functions-compat@0.4.3
Patch Changes
2f7f426]:@firebase/installations@0.6.21
Patch Changes
2f7f426]:@firebase/installations-compat@0.2.21
Patch Changes
2f7f426]:@firebase/messaging@0.12.25
Patch Changes
2f7f426]:@firebase/messaging-compat@0.2.25
Patch Changes
2f7f426]:@firebase/performance@0.7.11
Patch Changes
2f7f426]:@firebase/performance-compat@0.2.24
Patch Changes
2f7f426]:@firebase/remote-config@0.8.2
Patch Changes
2f7f426]:@firebase/remote-config-compat@0.2.23
Patch Changes
2f7f426]:@firebase/storage@0.14.2
Patch Changes
2f7f426#9608 - RemoveupdateEmulatorBanner(). (No release note needed.)Updated dependencies [
2f7f426]:@firebase/storage-compat@0.4.2
Patch Changes
2f7f426]: