feat(firestore): add timestamp expressions#9728
Conversation
🦋 Changeset detectedLatest commit: 6dd01c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Firestore's data pipeline functionality by introducing two new timestamp expressions: Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces timestamp_diff and timestamp_extract expressions for Firestore, enhancing its timestamp manipulation capabilities. The changes are well-implemented with corresponding API definitions, documentation, and both integration and lite tests. The documentation for timestamp_trunc examples has also been improved for consistency. My review found a minor inconsistency in the documentation that could be addressed.
milaGGL
left a comment
milaGGL
left a comment
There was a problem hiding this comment.
LGTM with minor comments
Add new timestamp expressions `timestamp_diff` and `timestamp_extract` and integration tests for the expressions The expression `timestamp_trunc` already existed in the repo with integration tests. Add methods for timestampTruncWithTimezone to avoid signature collision. Add methods to allow timezone as parameter in chained expressions. Amend the tests for the `timestamp_trunc` expression Ported from firebase/firebase-js-sdk#9728
4 participants
Add new timestamp expressions
timestamp_diffandtimestamp_extractand integration tests for the expressionsThe expression
timestamp_truncwas already ported in the repo with integration tests in firebase-js-sdk/packages/firestore/test/integration/api/pipeline.test.tsAdd extra integration tests for
timestamp_truncin firebase-js-sdk/packages/firestore/test/lite/pipeline.test.ts and amend the example usage documentation for standalone methodsBoth
timestamp_truncandtimestamp_extractuse overload implementation and have timeZone as optional argument