Skip to content

Migrate lsofi to v2 #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaopedrodcf wants to merge 2 commits into from
Closed

Migrate lsofi to v2 #10091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec6a16
Migrate lsofi to v2
joaopedrodcf Mar 13, 2026
bbe2073
Merge branch 'main' into joaopedrodcf/migrate_lsofi_v2
joehan Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 9 additions & 111 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
"leven": "^3.1.0",
"libsodium-wrappers": "^0.7.10",
"lodash": "^4.17.21",
"lsofi": "1.0.0",
"lsofi": "2.0.0",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This major version upgrade of lsofi to v2.0.0 is not accompanied by an update to its type definitions (@types/lsofi), which are for v1. This creates a risk of type mismatches and potential runtime errors.

To ensure type safety, the type definitions should be aligned with the new version. If lsofi v2 now includes its own types, @types/lsofi should be removed from devDependencies. If not, the existing types need to be validated and updated for v2 compatibility.

References
  1. Line 38 of the repository style guide emphasizes using proper interfaces/types. Upgrading a dependency to a new major version without updating its type definitions can lead to incorrect types being used, which goes against this principle. (link)

Copy link
Copy Markdown
Author

@joaopedrodcf joaopedrodcf Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types didn't;t change that's why they weren't updated, this major is major because it changes the required node version, and removes a lot of internal dependencies while keeping the same behavior

"marked": "^13.0.2",
"marked-terminal": "^7.0.0",
"mime": "^2.5.2",
Expand Down
Loading