-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add basic 1st gen functions support #10119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
inlined
wants to merge
18
commits into
main
Choose a base branch
from
inlined.iac.3-cloud-functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d0774a7
feat: sort HCL attributes by category
inlined a565e1d
PR feedback
inlined 6c4e3d6
Make tests show pretty strings
inlined 2af7727
feat: add terraform exporter for cloud functions
inlined ecbd226
PR feedback
inlined 8f149e6
PR feedback. DRY IAM TF
inlined f41f503
Pretty printing
inlined 767d88a
Prettier printing. terraform.tf. out param
inlined 3afaddc
PR feedback
inlined 2a42921
Merge branch 'main' into inlined.iac.2.5-pretty-print
inlined 3ecdfdf
Formatter
inlined f36fa44
PR feedback
inlined 9da3e54
Merge branch 'inlined.iac.2.5-pretty-print' into inlined.iac.3-cloud-…
inlined edf6bcb
Merg fixes & ordering. Now to fix up test oracles
inlined 91be43e
Play with formatting more & fixing tests
inlined 115b00d
Explicitly join without any delimiter
inlined b3fa5ee
Merge branch 'main' into inlined.iac.3-cloud-functions
inlined 86d5fbd
Merge branch 'main' into inlined.iac.3-cloud-functions
inlined File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you assert on the entire string, instead of includes, kind of like minion? This will also allow me to see a full example in case there are any missed edges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a bunch of work to create good looking formatted strings. Take another look.