Implement ListSupportedRuntime usage for runtimes (dynamically popula…#10139
Implement ListSupportedRuntime usage for runtimes (dynamically popula…#10139
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the App Hosting setup experience by making the runtime selection dynamic. Instead of relying on a static list, the system now queries the backend for available runtimes, providing users with up-to-date options and improving the adaptability of the setup process to new runtime versions or types. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully implements dynamic population of supported runtimes for App Hosting backends. The changes introduce new interfaces, a dedicated API function to fetch runtimes, and integrate this functionality into the setup process with appropriate error handling and a fallback mechanism. A relevant unit test has also been added for the new API function. The overall approach enhances flexibility and maintainability by reducing hardcoded values.
| const supportedRuntimes = await apphosting.listSupportedRuntimes(projectId, location); | ||
| for (const r of supportedRuntimes) { | ||
| if (r.runtimeId !== DEFAULT_RUNTIME) { | ||
| choices.push({ name: r.runtimeId, value: r.runtimeId }); |
There was a problem hiding this comment.
For dynamically listed runtimes, it would be more user-friendly to display the name property from the SupportedRuntime interface rather than just the runtimeId. The SupportedRuntime interface already includes a name field that can be used for this purpose.
| choices.push({ name: r.runtimeId, value: r.runtimeId }); | |
| choices.push({ name: r.name, value: r.runtimeId }); |
…te them)
Description
Scenarios Tested
Sample Commands