Skip to content

Implement ListSupportedRuntime usage for runtimes (dynamically popula…#10139

Draft
falahat wants to merge 3 commits intomainfrom
listsupportedruntimes
Draft

Implement ListSupportedRuntime usage for runtimes (dynamically popula…#10139
falahat wants to merge 3 commits intomainfrom
listsupportedruntimes

Conversation

@falahat
Copy link
Contributor

@falahat falahat commented Mar 20, 2026

…te them)

Description

Scenarios Tested

Sample Commands

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the App Hosting setup experience by making the runtime selection dynamic. Instead of relying on a static list, the system now queries the backend for available runtimes, providing users with up-to-date options and improving the adaptability of the setup process to new runtime versions or types.

Highlights

  • Dynamic Runtime Selection: The runtime selection process during App Hosting setup now dynamically fetches available runtimes from the backend using a new API call, replacing the previously hardcoded options.
  • New API Integration: Integrated a new listSupportedRuntimes API endpoint to retrieve a list of supported runtimes for a given project and location.
  • Error Handling: Implemented error handling for the listSupportedRuntimes API call, falling back to the default runtime if the API call fails.
  • Type Definitions: Added new TypeScript interfaces (SupportedRuntime, ListSupportedRuntimesResponse) to define the structure of the data returned by the new API.
  • Unit Testing: Included a new unit test case to verify the functionality of the listSupportedRuntimes API client.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully implements dynamic population of supported runtimes for App Hosting backends. The changes introduce new interfaces, a dedicated API function to fetch runtimes, and integrate this functionality into the setup process with appropriate error handling and a fallback mechanism. A relevant unit test has also been added for the new API function. The overall approach enhances flexibility and maintainability by reducing hardcoded values.

const supportedRuntimes = await apphosting.listSupportedRuntimes(projectId, location);
for (const r of supportedRuntimes) {
if (r.runtimeId !== DEFAULT_RUNTIME) {
choices.push({ name: r.runtimeId, value: r.runtimeId });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For dynamically listed runtimes, it would be more user-friendly to display the name property from the SupportedRuntime interface rather than just the runtimeId. The SupportedRuntime interface already includes a name field that can be used for this purpose.

Suggested change
choices.push({ name: r.runtimeId, value: r.runtimeId });
choices.push({ name: r.name, value: r.runtimeId });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants