Fix storage emulator crash on invalid JWT and add unit tests

[brittanycho]

Branched from #10134 to unblock stalled tests

See further context in PR #10134

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and reliability of the Firebase Storage emulator by addressing a critical issue where invalid JWTs could lead to a crash. It ensures that the emulator's authentication logic is more resilient to malformed input and includes comprehensive unit tests to validate this improved behavior.

Highlights

• Storage Emulator Stability: Resolved a potential crash in the Storage emulator when an invalid JSON Web Token (JWT) was provided, ensuring the emulator now gracefully handles malformed tokens by returning a null authentication value.
• Unit Test Coverage: Introduced new unit tests for the createAuthExpressionValue function to verify its behavior with missing, invalid, and valid JWTs, improving the robustness and reliability of the authentication logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a crash in the storage emulator caused by invalid JWTs. The changes in createAuthExpressionValue now properly handle invalid or non-object token payloads by returning null, preventing the crash. The addition of unit tests in runtime.spec.ts is excellent, covering missing, invalid, and decodable tokens, which ensures the fix is robust and prevents future regressions. The code quality is high, adhering to the repository's best practices by removing an any type cast and reducing nesting. Overall, this is a solid fix and a great contribution.

[brittanycho]

Actually this PR is not necessary, hub + git push should allow the tests to run on the original PR - closing