Skip to content

Migrate to use SWC#10142

Closed
maneesht wants to merge 6 commits intomainfrom
mtewani/migrate-to-esbuild
Closed

Migrate to use SWC#10142
maneesht wants to merge 6 commits intomainfrom
mtewani/migrate-to-esbuild

Conversation

@maneesht
Copy link
Contributor

Replaced tsc with SWC.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request migrates the project's build system from TypeScript Compiler (TSC) to SWC, a significantly faster JavaScript/TypeScript compiler. The changes involve updating the build script in package.json, adding necessary SWC and Tsup dependencies, and introducing new configuration files for these tools. The primary goal is to enhance compilation performance and optimize the overall build process.

Highlights

  • SWC Integration: The primary build script has been updated to use SWC (Speedy Web Compiler) instead of TypeScript Compiler (TSC), aiming for faster compilation times.
  • New Build Tooling: New development dependencies, including @swc/cli, @swc/core, and tsup, have been added to facilitate the SWC-based build and bundling process.
  • Configuration Files Added: A new .swcrc file has been introduced to configure SWC's compilation settings, and tsup.config.ts was added for bundling configurations.
  • TypeScript Configuration Updates: The tsconfig.json file was modified to enable incremental compilation and remove the explicit include property, streamlining the TypeScript configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the build process from tsc to swc, which should improve build performance. However, I've identified a critical runtime error due to a missing import, a significant logic bug in error handling, and a potential tooling issue with the tsconfig.json that need to be addressed to ensure correctness and maintainability.

@maneesht maneesht closed this Mar 20, 2026
@maneesht
Copy link
Contributor Author

Closing as SWC doesn't do type checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants