Skip to content

feat(fdc): Streaming implementation for data connect#18174

Open
aashishpatil-g wants to merge 13 commits intomainfrom
ap/pasta
Open

feat(fdc): Streaming implementation for data connect#18174
aashishpatil-g wants to merge 13 commits intomainfrom
ap/pasta

Conversation

@aashishpatil-g
Copy link
Copy Markdown
Contributor

Implements streaming support in Firebase Data Connect for subscribe().

* Initial Commit

* Fix formatting and analyzer warnings

* Fix tests and licenses

* Denver feedback: var initialization best practice

* sorted keys for id generation

* Fix analyze info messages
* Handle disconnects and reconnects

* Address gemini review comments

* Reconnection logic

* Fixes to reconnect on startup

* Fix to decode binary data from server

* Handle gemini feedback

* Update rest_transport mocks with new windows provider sig
* debug logging and hardering

* Hardening: ensure only one multicast stream controller is created in a ref

* Handle cancellations

* Formatting fix
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@aashishpatil-g
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements real-time streaming support for the Firebase Data Connect SDK by introducing a WebSocket-based transport layer and a new streaming protocol. It transitions the library from gRPC to a hybrid REST and WebSocket approach, managed by a routing transport. Feedback highlights critical issues regarding resource management, specifically the potential for leaked WebSocket connections and memory leaks from uncancelled subscriptions. Other recommendations include optimizing the expensive operation ID generation, ensuring consistency by making variables final, and adhering to style guidelines regarding function length and the use of the non-null assertion operator.

@cynthiajoan cynthiajoan requested a review from Lyokone April 8, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants