Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,14 @@ FirebaseException _firebaseExceptionFromCoreFirebaseError(
///
/// See also https://github.com/dart-lang/sdk/issues/30741
bool _testException(Object? objectException) {
final exception = objectException! as core_interop.JSError;
if (objectException is! core_interop.JSError) {
return false;
}

final message = _safeConvertFromPossibleJSObject(exception.message);
final message = _safeConvertFromPossibleJSObject(objectException.message);
// Firestore web does not contain `Firebase` in the message so we check the exception itself.
return message.contains('Firebase') ||
exception.toString().contains('FirebaseError');
objectException.toString().contains('FirebaseError');
}

/// Transforms internal errors in something more readable for end-users.
Expand Down
13 changes: 13 additions & 0 deletions packages/_flutterfire_internals/test/guard_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,19 @@ void main() {
expect(stack, current);
}
});

test(
'propagates plain Dart errors from Futures (e.g. ArgumentError on web)',
() async {
await expectLater(
guardWebExceptions(
() => Future<void>.error(ArgumentError('test')),
plugin: 'test',
codeParser: (c) => c,
),
throwsA(isA<ArgumentError>()),
);
});
});
}

Expand Down
Loading