Support Bera symbol and expand withdrawal status enum#230
Conversation
| - rejected | ||
| - cancelled | ||
| - processing |
There was a problem hiding this comment.
Is it a product requirement?
In any case, now that there are 6 possible values, their meaning should be documented. Especially the difference between pending and processing — they sound as the same status. Moreover, ideally we should have tests that validate these statuses are used correctly; e.g., cancel a withdrawal and validate that the status is "cancelled". But I am not sure how possible that is.
There was a problem hiding this comment.
@yanivmo this was a payments team requirement for WorldPay. Will ask them to add a detailed meaning for every field. since we already support it I think it is better to publish it and then add another MR.
if you disagree I'll split this MR into two MRs publish BERA symbol support info. Let me know, Thanks
PolinaLif
force-pushed
the
supprot-bera
branch
2 times, most recently
from
609e293 to
8bec2b9
Compare
[FIREHOG-BYPASS] not relvant, file from main branch
2 participants
No description provided.