Provide set of converged reasons for each PETSc object type#12
Open
JHopeCollins wants to merge 1 commit intomainfrom
Open
Provide set of converged reasons for each PETSc object type#12JHopeCollins wants to merge 1 commit intomainfrom
JHopeCollins wants to merge 1 commit intomainfrom
Conversation
connorjward
requested changes
Jul 16, 2025
Collaborator
There was a problem hiding this comment.
I don't know what this is supposed to be doing. Can this get some documentation?
Also is KSPReasons (for example) the best choice of name. I am unfamiliar with the code but would KSPConvergedReasons be better? (Just from looking at the petsc4py API we build on)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firedrake has
KSPReasonsandSNESReasons, and the TAO solve in pyadjoint hasTAOReasons. We may as well provide the full set here for everyone to use.