Skip to content

Some fixes to the profile merging code#5802

Merged
mstange merged 4 commits intofirefox-devtools:mainfrom
mstange:some-merging-fixes
Feb 3, 2026
Merged

Some fixes to the profile merging code#5802
mstange merged 4 commits intofirefox-devtools:mainfrom
mstange:some-merging-fixes

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented Jan 30, 2026

More small stuff that makes #5482 a tiny bit easier.

@mstange mstange requested a review from canova January 30, 2026 20:20
@mstange mstange force-pushed the some-merging-fixes branch from bb6b6c7 to 30d7152 Compare January 30, 2026 20:21
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.65%. Comparing base (b194aed) to head (89082f8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5802   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         319      319           
  Lines       31343    31343           
  Branches     8546     8546           
=======================================
  Hits        26846    26846           
  Misses       4066     4066           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange force-pushed the some-merging-fixes branch from 30d7152 to b194aed Compare February 2, 2026 14:56
Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mstange mstange enabled auto-merge February 3, 2026 14:58
@mstange mstange merged commit c08fe8a into firefox-devtools:main Feb 3, 2026
19 checks passed
@canova canova mentioned this pull request Feb 4, 2026
canova added a commit that referenced this pull request Feb 4, 2026
Changes:

[Nazım Can Altınova] Make the range duration text white again (#5792)
[Alex Thayer] Display traced values in Stack Chart view (#5363)
[Nazım Can Altınova] Improve the JS traced arguments visualization in
call node tooltips (#5795)
[Markus Stange] Make the argument-values.json profile fixture go through
profile upgrading (#5796)
[Markus Stange] Add thread.usedInnerWindowIDs to the processed profile
format (#5780)
[fatadel] Fix context menu and hover preview z-index (#5797)
[fatadel] add TrackPower--tooltip-power-microwatt (#5799)
[Markus Stange] Two small test fixes (#5801)
[fatadel] fix selected thread pid color in light mode (#5805)
[Markus Stange] Some fixes to the profile merging code (#5802)
[fatadel] fix disabled button color in dark mode (#5808)
[fatadel] add comment for uptime label translation (#5806)
[Nazım Can Altınova] Add a theme toggle to the home page and follow the
system theme by default (#5800)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (Feb 4, 2025) (#5813)

And huge thanks to our localizers:

de: Ger
de: Michael Köhler
de: Nazım Can Altınova
el: Jim Spentzos
en-GB: Ian Neal
es-CL: ravmn
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Mark Heijl
pt-BR: Marcelo Ghelman
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
tr: Selim Şumlu
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants