Skip to content

chore: fix broken links#1765

Merged
reubenyap merged 3 commits intofiroorg:masterfrom
VolodymyrBg:link
Mar 19, 2026
Merged

chore: fix broken links#1765
reubenyap merged 3 commits intofiroorg:masterfrom
VolodymyrBg:link

Conversation

@VolodymyrBg
Copy link
Copy Markdown
Contributor

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1a35076c-063b-41fa-b84f-c9153cb1fe5f

📥 Commits

Reviewing files that changed from the base of the PR and between 55941fc and 725e64f.

📒 Files selected for processing (1)
  • doc/developer-notes.md
✅ Files skipped from review due to trivial changes (1)
  • doc/developer-notes.md

Walkthrough

Updated two textual links: a Doxygen reference in doc/developer-notes.md was changed to a Markdown multi-line link pointing to https://www.doxygen.nl/manual/docblocks.html, and a cppreference URL in a comment in src/immer/detail/type_traits.hpp was corrected to https://en.cppreference.com/w/cpp/iterator.html.

Changes

Cohort / File(s) Summary
Documentation
doc/developer-notes.md
Replaced legacy Doxygen URL with a Markdown multi-line link labelled "the Doxygen docblocks reference" pointing to https://www.doxygen.nl/manual/docblocks.html.
Source comment
src/immer/detail/type_traits.hpp
Updated a comment link for the iterator concept from http://en.cppreference.com/w/cpp/concept/Iterator to https://en.cppreference.com/w/cpp/iterator.html.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 I hopped through links both old and new,
Swapped http for https, a tiny chew,
Doxygen and cppref now gleam,
Docs tidy and links supreme,
A little rabbit clap—hop, review!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides a concise list of the broken links and their corrected versions, but it lacks the mandatory 'PR intention' section structure specified in the template. Add a 'PR intention' section that explicitly describes what this PR does and what issue it solves, following the repository's description template structure.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: fix broken links' directly and clearly describes the main purpose of the PR: fixing broken links in documentation and code comments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@doc/developer-notes.md`:
- Around line 107-108: Replace the bare URL in the sentence "A full list of
comment syntaxes picked up by doxygen can be found at
https://www.doxygen.nl/manual/docblocks.html" with a markdown link (e.g., "A
full list of comment syntaxes picked up by doxygen can be found at [Doxygen
docblocks](https://www.doxygen.nl/manual/docblocks.html)") so the file no longer
violates MD034; update the doc string accordingly wherever that bare URL
appears.

Comment thread doc/developer-notes.md Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Mar 19, 2026
Replace broken doxygen link (stack.nl 404) with current doxygen.nl URL.
Replace broken cppreference Iterator concept link with the correct
named_req/Iterator URL (the LegacyIterator named requirement page),
not the general iterator library page.

Both old links return HTTP 404; both replacements return HTTP 200.
Also upgrade http:// to https:// for both URLs.

refs #1765

Co-authored-by: Reuben Yap <reuben@firo.org>
@firoorg firoorg deleted a comment from cursor Bot Mar 19, 2026
@firoorg firoorg deleted a comment from cursor Bot Mar 19, 2026
@reubenyap reubenyap merged commit a7ade94 into firoorg:master Mar 19, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants