Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new vapi peer type to the server notifications protocol so peers can be classified as VAPI in server→peer messages and generated artifacts/docs stay in sync.
Changes:
- Added
PEER_TYPE_VAPI = 3toServerMessage.PeerTypeinserver_notifications.proto. - Updated the checked-in Elixir Protobuf output to include the new enum value.
- Updated the rendered docs table for
ServerMessage.PeerTypeto list the new value.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fishjam/server_notifications.proto | Extends ServerMessage.PeerType with PEER_TYPE_VAPI. |
| fishjam_protos/lib/fishjam/server_notifications.pb.ex | Keeps generated Elixir enum definitions aligned with the .proto change. |
| doc/docs.md | Updates enum documentation to include PEER_TYPE_VAPI with number 3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AHGIJMKLKKZNPJKQR
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact