feat: add article, collection, and help_center models by fivetran-catfritz · Pull Request #74 · fivetran/dbt_intercom

fivetran-catfritz · 2025-12-11T16:33:13Z

PR Overview

Package version introduced in this PR:

v1.4.0

This PR addresses the following Issue/Feature(s):

[Feature] Add article support #72

Summary of changes:

Data Model(s)	Change type	Notes
`stg_intercom__article_history` `stg_intercom__article_history_tmp`	New models	Staging models for the `article_history` source
`stg_intercom__collection_history` `stg_intercom__collection_history_tmp`	New models	Staging models for the `collection_history` source
`stg_intercom__help_center_history` `stg_intercom__help_center_history_tmp`	New models	Staging models for the `help_center_history` source
`intercom__article_enhanced`	New model	Help center articles enhanced with metadata including author details, collection hierarchy, and performance statistics

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

* feat: add article, collection, and help_center models * add changelog and verions updates * Update CHANGELOG.md * updating final model * updating final model * updating version feedback * updating per PR feedback to move intermediate model to final

dbt_project.yml

…dbt_intercom into feature/article-models merge

integration_tests/dbt_project.yml

…dbt_intercom into feature/article-models merge again

…dbt_intercom into feature/article-models merge

fivetran-jamie

Looks great! Left a couple of targeted comments, but I also wanted to discuss the larger question of creating specific variables for collection_history and help_center_history, especially with the context of ERTC coming soon.

Pre-ERTC: With the current setup, we'll create empty models for collection_history and help_center_history if they are missing but article_history is present. These tables are less popular, so this could happen.

Post-ERTC: With the current setup, if collection_history or help_center_history is missing but article_history is not, the Article model will be disabled. Should this be the case? If not, we should create variables. We could still include intercom__using_articles in the enabled conditions since these tables aren't really helpful without articles

dbt_project.yml

models/intercom__article_enhanced.sql

README.md

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

fivetran-catfritz

@fivetran-jamie I made the changes and added the vars. I'm not sure about how I set up the staging vars though.

dbt_project.yml

README.md

dbt_project.yml

fivetran-jamie

Looks great! I like the way you set up the variables -- it's very much optimized for how they relate to each other. Just two doc requests, but this is approved!

I think a release review would be good here though. I can handle any making any adjustments and releasing on Monday!

README.md

fivetran-jamie · 2025-12-12T22:44:21Z

.buildkite/scripts/run_models.sh

 dbt run --vars '{intercom__using_articles: false, intercom__using_contact_company: false, intercom__using_company_tags: false, intercom__using_contact_tags: false, intercom__using_conversation_tags: false, intercom__using_team: false}' --target "$db"
-dbt test --target "$db" --vars '{intercom__using_articles: false,intercom__using_contact_company: false, intercom__using_company_tags: false, intercom__using_contact_tags: false, intercom__using_conversation_tags: false, intercom__using_team: false}'
+dbt test --target "$db" --vars '{intercom__using_articles: false, intercom__using_contact_company: false, intercom__using_company_tags: false, intercom__using_contact_tags: false, intercom__using_conversation_tags: false, intercom__using_team: false}'
+# only need to test intercom__article_enhanced and its upstreams for these vars:


Very nice, we should do this more when testing variables

fivetran-jamie · 2025-12-12T22:51:28Z

CHANGELOG.md

+| `stg_intercom__article_history`<br>`stg_intercom__article_history_tmp` | New models | | | Staging models for the `article_history` source |
+| `stg_intercom__collection_history`<br>`stg_intercom__collection_history_tmp` | New models | | | Staging models for the `collection_history` source |
+| `stg_intercom__help_center_history`<br>`stg_intercom__help_center_history_tmp` | New models | | | Staging models for the `help_center_history` source |
+| `intercom__article_enhanced` | New model | | | Help center articles enhanced with metadata including author details, collection hierarchy, and performance statistics |


Could you move this one to be the first line?

…dbt_intercom into feature/article-models merge

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

fivetran-joemarkiewicz

LGTM

fivetran-catfritz self-assigned this Dec 11, 2025

fivetran-catfritz linked an issue Dec 11, 2025 that may be closed by this pull request

[Feature] Add article support #72

Closed

4 tasks

fivetran-catfritz changed the title ~~feat: add article, collection, and help_center models (#73)~~ feat: add article, collection, and help_center models Dec 11, 2025

fivetran-catfritz mentioned this pull request Dec 11, 2025

feat: add article, collection, and help_center models #73

Merged

4 tasks

fivetran-catfritz added 6 commits December 11, 2025 13:24

fix quoting issues

77c69a0

add consistency test

fc3387e

add consistency test

3c09141

update format

d352170

changelog

d874467

changelog

a2f9aac

fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Dec 11, 2025

Generate dbt docs via GitHub Actions

06aab4b

fivetran-catfritz commented Dec 11, 2025

View reviewed changes

dbt_project.yml Outdated Show resolved Hide resolved

fivetran-catfritz added 2 commits December 11, 2025 15:32

updates

c141d79

Merge branch 'feature/article-models' of https://github.com/fivetran/…

62495ee

…dbt_intercom into feature/article-models merge

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Dec 11, 2025

Generate dbt docs via GitHub Actions

36447cb

fivetran-catfritz commented Dec 11, 2025

View reviewed changes

integration_tests/dbt_project.yml Show resolved Hide resolved

fivetran-catfritz added 3 commits December 11, 2025 15:44

remove extra whitespace

d4e4aca

formatting

9d05d69

Merge branch 'feature/article-models' of https://github.com/fivetran/…

137fbbd

…dbt_intercom into feature/article-models merge again

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Dec 11, 2025

github-actions bot and others added 3 commits December 11, 2025 21:47

Generate dbt docs via GitHub Actions

7cbbe98

formatting again

63ee455

Merge branch 'feature/article-models' of https://github.com/fivetran/…

8c3b40f

…dbt_intercom into feature/article-models merge

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Dec 11, 2025

fivetran-catfritz requested a review from fivetran-jamie December 11, 2025 21:51

github-actions bot and others added 2 commits December 11, 2025 21:51

Generate dbt docs via GitHub Actions

279dee9

Update README.md

7ad48b7

fivetran-jamie reviewed Dec 12, 2025

View reviewed changes

dbt_project.yml Outdated Show resolved Hide resolved

dbt_project.yml Outdated Show resolved Hide resolved

models/intercom__article_enhanced.sql Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

fivetran-catfritz and others added 2 commits December 12, 2025 15:08

Update models/intercom__article_enhanced.sql

74942e4

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

review updates

2ceb6ec

fivetran-catfritz commented Dec 12, 2025

View reviewed changes

dbt_project.yml Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

dbt_project.yml Outdated Show resolved Hide resolved

run_models

527b166

fivetran-catfritz removed the docs:ready Triggers the docs generator workflow. label Dec 12, 2025

fivetran-jamie approved these changes Dec 12, 2025

View reviewed changes

fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Dec 12, 2025

github-actions bot and others added 5 commits December 12, 2025 22:58

Generate dbt docs via GitHub Actions

261811b

run_models

1375abc

Merge branch 'feature/article-models' of https://github.com/fivetran/…

3893aca

…dbt_intercom into feature/article-models merge

changelog

8900ffa

Update README.md

597a7bf

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

fivetran-joemarkiewicz approved these changes Dec 15, 2025

View reviewed changes

fivetran-jamie merged commit 074c27d into main Dec 15, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add article, collection, and help_center models#74

feat: add article, collection, and help_center models#74
fivetran-jamie merged 27 commits intomainfrom
feature/article-models

fivetran-catfritz commented Dec 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fivetran-jamie left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-catfritz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-jamie left a comment •

edited

Loading

Uh oh!

Uh oh!

fivetran-jamie Dec 12, 2025

Uh oh!

fivetran-jamie Dec 12, 2025

Uh oh!

fivetran-joemarkiewicz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fivetran-catfritz commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

Uh oh!

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-catfritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-jamie left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fivetran-jamie Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

fivetran-jamie Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fivetran-catfritz commented Dec 11, 2025 •

edited

Loading

fivetran-jamie left a comment •

edited

Loading