bugfix/assignee_type_deprecation#75
Merged
fivetran-joemarkiewicz merged 9 commits intomainfrom Jan 14, 2026
Merged
Conversation
fivetran-joemarkiewicz
added
the
docs:ready
fivetran-savage
approved these changes
Dec 23, 2025
Contributor
fivetran-savage
left a comment
fivetran-savage
left a comment
There was a problem hiding this comment.
Just one small question but nothing preventing approval, especially for pre-release. Approved!
CHANGELOG.md
Outdated
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | ----| --- | ----- | | ||
| | `intercom__conversation_enhanced`<br>`intercom__conversation_metrics` | New field | | `conversation_assignee_id` | Exposes the assignee ID from the staging layer for reference and joining purposes | |
Contributor
There was a problem hiding this comment.
Do we need a more explicit description of what the assignee_id field is/does?
Contributor
Author
There was a problem hiding this comment.
It could be useful to add that detail to the CHANGELOG. Added a short detailed description which mirrors the docs to the CHANGELOG entry in the latest commit.
fivetran-joemarkiewicz
added
the
pre-release
Contributor
fivetran-savage
left a comment
fivetran-savage
left a comment
There was a problem hiding this comment.
PR looks great overall. Just one suggestion in terms of the description of the new column in the changelog.
fivetran-joemarkiewicz
removed
the
pre-release
fivetran-savage
approved these changes
Jan 13, 2026
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
assignee_typefield from theCONVERSATION_HISTORYsource table as this has been deprecated. The field has been listed as deprecated and a new fieldis_assignee_adminis being added for use in the downstreamintercom__admin_metricsmodel.Submission Checklist
Changelog