feat(flame_3d): Allow shader uniform structures use array elements#3878
Merged
wolfenrain merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
luanpotter
reviewed
Mar 24, 2026
luanpotter
reviewed
Mar 24, 2026
luanpotter
reviewed
Mar 24, 2026
luanpotter
approved these changes
Mar 24, 2026
Member
luanpotter
left a comment
There was a problem hiding this comment.
This is an amazing step forward!
I'd love to support these though:
- arrays of structs - I didn't recall seeing anything on spec that says it wouldn't work (but it didn't)
- arbitrary length arrays with SSBOs
the 16 joint limit can be quite limiting even with my per-node optmization
Contributor
Author
I kept the implementation the same and we can explore arbitrary length SSBOs later, there was a limit on uniforms that we should get verified to make sure if we can or can not increase the joint limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for array elements in shaders, which allows us to simplify our light system and joint logic
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues