Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for the SSE middleware, detailing its installation and providing usage examples.
- Introduces a new SSE middleware documentation file (docs/middleware/sse.md) with installation instructions, code examples, and template integration.
- Updates the middleware index (docs/middleware/README.md) to include a link to the new SSE documentation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/middleware/sse.md | Adds the SSE middleware documentation with examples. |
| docs/middleware/README.md | Updates the middleware list to include SSE. |
Comment on lines
+54
to
+56
| for { | ||
| select { | ||
| case <-time.Tick(1 * time.Second): |
There was a problem hiding this comment.
Consider moving time.Tick(1 * time.Second) outside the loop to avoid creating a new ticker on every iteration, which could lead to resource inefficiencies.
Suggested change
| for { | |
| select { | |
| case <-time.Tick(1 * time.Second): | |
| ticker := time.NewTicker(1 * time.Second) | |
| defer ticker.Stop() | |
| for { | |
| select { | |
| case <-ticker.C: |
✅ Deploy Preview for keen-austin-23ca57 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
A clear and concise description of what the pull request is about, i.e. what problem should be fixed?
Link to the issue: flamego/flamego#124
Checklist