feat: add loading indicator between view pages transition#2952
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe changes add a transition overlay feature to the view container. The Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/views/components/ViewContainer.tsx`:
- Around line 121-123: The wrapper div in ViewContainer uses "overflow-hidden"
which can clip inline-rendered chart tooltips; confirm whether
ChartTooltipContent tooltips overflow in your UI and, if they do, update
ChartTooltipContent to render its tooltip into document.body via the same portal
pattern used by MultiSelectDropdown, TristateReactSelect, and Tooltip (i.e.,
create a portal root and mount the tooltip DOM there) so chart tooltips are not
clipped while keeping the wrapper's overflow-hidden intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8bcdfd74-7b97-4169-acf7-7302029007f4
📒 Files selected for processing (2)
src/pages/views/components/ViewContainer.tsxsrc/pages/views/hooks/useViewData.ts
Summary by CodeRabbit