Fixed issue #3692#4214
Closed
edgeinfinity1 wants to merge 5 commits intoflarum:2.xfrom
Closed
Conversation
Contributor
Author
|
Member
|
Hi @edgeinfinity1 sorry it's taken us so long here 🙈 I've taken your work here as a starting point and tried to implement a little more egegantly as you suggest in #4379 I'll close this PR now and focus on the new one. Thanks for this, really appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Fixing an issue causing users unable to rename their posts, which has been confirmed at #3692
Reviewers should focus on:
This is a rather brutal fix, since I'm not too into flarum. Please consider rewriting this in an elegant way.
At least I have confirmed it working on my own deployment at https://forum.monika.love
Screenshot
Necessity
Confirmed
composer test).