fix(coreos-cloudinit): truncate hostnames#2806
Merged
tormath1 merged 1 commit intoflatcar:mainfrom Apr 10, 2025
Merged
Conversation
...ner/src/third_party/coreos-overlay/coreos-base/coreos-cloudinit/coreos-cloudinit-9999.ebuild
Outdated
Show resolved
Hide resolved
RiRa12621
force-pushed
the
rira12621-cloudinit
branch
from
80febba to
4f8819e
Compare
Author
|
fixed @sayanchowdhury |
sayanchowdhury
approved these changes
Apr 8, 2025
tormath1
moved this to ✅ Testing / in Review
in Flatcar tactical, release planning, and roadmap
github-project-automation
bot
moved this from ✅ Testing / in Review
to Implemented
in Flatcar tactical, release planning, and roadmap
Contributor
|
@RiRa12621 thanks for the contribution. This will be available in the next Alpha release and in the nightlies (https://bincache.flatcar-linux.net/images/amd64/). We still need to discuss if we want this in Beta as well. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/14382115495 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
truncate too long hostnames
Long hostnames can have unexpected consequences and this makes the truncation behavior explicit
This also cleans up existing truncating in AWS
How to use
A new node that uses cloud-init and has an overly long host name.
Technically the second case should never happen, because most cloud providers are attempting to block direct instance names longer than 63 chars, but rather safe than sorry.
Testing done
Test added for
..is still too longchangelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.