Draft
Conversation
sayanchowdhury
force-pushed
the
sayan/publish-nightlies-sig
branch
from
8999878 to
85622c1
Compare
chewi
requested changes
Aug 4, 2025
Contributor
chewi
left a comment
chewi
left a comment
There was a problem hiding this comment.
Nice work, thanks.
Just a general tip, although Gentoo is admittedly quote-heavy in its ebuilds, you don't need to quote:
- When assigning
FOO=${}orFOO=$() - Inside
[[ ]]unless it's a variable on the right-hand-side. case ${FOO} in
sayanchowdhury
force-pushed
the
sayan/publish-nightlies-sig
branch
from
1d2fb49 to
1033348
Compare
Co-authored-by: James Le Cuirot <jlecuirot@microsoft.com> Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
sayanchowdhury
force-pushed
the
sayan/publish-nightlies-sig
branch
from
1033348 to
2247dd3
Compare
sayanchowdhury
had a problem deploying
to
development
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged with https://github.com/flatcar/jenkins-os/pull/371
The script publishes vhd images to Azure Shared Image Galleries
Pending Item:
az_sig_publish. lbzip2 is not available in package repos. Also, need to check if curl works.CI http://jenkins.infra.kinvolk.io:8080/job/container/job/az_sig_publish/98/consoleFull