fix(docker): Set explicit container_name on all services#83
Merged
Conversation
EnsureContainerName only named the primary service, leaving others
with Docker Compose auto-generated names. This caused cron jobs and
backups to fail when targeting secondary services using the
{deploymentName}-{serviceName} convention.
EnsureContainerNames now sets container_name on every service:
primary gets {deploymentName}, others get {deploymentName}-{service}.
Existing container_name values are preserved. The compose file is
patched automatically on start/restart/rebuild, so existing
deployments pick up correct names on next restart.
Closes #82
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThis PR fixes an issue where only the primary service was assigned a static container name, causing targeting issues for cron jobs/backups on secondary services. It now ensures every service in a compose file has an explicit 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnsureContainerName only named the primary service, leaving others with Docker Compose auto-generated names. This caused cron jobs and backups to fail when targeting secondary services using the {deploymentName}-{serviceName} convention.
EnsureContainerNames now sets container_name on every service: primary gets {deploymentName}, others get {deploymentName}-{service}. Existing container_name values are preserved. The compose file is patched automatically on start/restart/rebuild, so existing deployments pick up correct names on next restart.
Closes #82